From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#12492: Acknowledgement (24.2.50; Open vc-dir buffer easier and faster) Date: Wed, 04 Mar 2020 01:27:16 +0200 Organization: LINKOV.NET Message-ID: <878skhyq7f.fsf@mail.linkov.net> References: <505E43E1.9090801@yandex.ru> <505E4A57.5020305@yandex.ru> <871rzer8t2.fsf@mail.linkov.net> <87y2sny796.fsf@mail.linkov.net> <12916780-e746-824f-f386-e90cf03087bc@yandex.ru> <87wo822wmt.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="20660"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 12492@debbugs.gnu.org, Lars Ingebrigtsen To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 04 01:11:35 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9HdN-0005Fg-8s for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Mar 2020 01:11:33 +0100 Original-Received: from localhost ([::1]:55410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9HdM-0005Bs-Ae for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Mar 2020 19:11:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37821) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9Hct-0004Mn-Ur for bug-gnu-emacs@gnu.org; Tue, 03 Mar 2020 19:11:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9Hcs-0006LR-Tv for bug-gnu-emacs@gnu.org; Tue, 03 Mar 2020 19:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34195) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9Hcs-0006LK-QW for bug-gnu-emacs@gnu.org; Tue, 03 Mar 2020 19:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9Hcs-0005WQ-M2 for bug-gnu-emacs@gnu.org; Tue, 03 Mar 2020 19:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Mar 2020 00:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12492 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12492-submit@debbugs.gnu.org id=B12492.158328065221180 (code B ref 12492); Wed, 04 Mar 2020 00:11:02 +0000 Original-Received: (at 12492) by debbugs.gnu.org; 4 Mar 2020 00:10:52 +0000 Original-Received: from localhost ([127.0.0.1]:40162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9Hci-0005VY-73 for submit@debbugs.gnu.org; Tue, 03 Mar 2020 19:10:52 -0500 Original-Received: from bird.elm.relay.mailchannels.net ([23.83.212.17]:61247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9Hcg-0005VM-Fl for 12492@debbugs.gnu.org; Tue, 03 Mar 2020 19:10:50 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 526BC3C0DAB; Wed, 4 Mar 2020 00:10:49 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a71.g.dreamhost.com (100-96-38-106.trex.outbound.svc.cluster.local [100.96.38.106]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C4D7F3C0D32; Wed, 4 Mar 2020 00:10:48 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a71.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 04 Mar 2020 00:10:49 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Keen-Quick: 6498c9756cdd4cdc_1583280649035_3995752087 X-MC-Loop-Signature: 1583280649035:3364618384 X-MC-Ingress-Time: 1583280649034 Original-Received: from pdx1-sub0-mail-a71.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a71.g.dreamhost.com (Postfix) with ESMTP id 0E53E7F5C0; Tue, 3 Mar 2020 16:10:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=eh7frMADz5wlBokXcwawG7/UX1c=; b= I6bTBL/5j+YbNPSs7EPPI6ExNE1Sx7G52n+/fX9rC/Jj9qlsBwMqte9iUxH/ap8W 4gRInUD4xfiB7PkBJbHzffZN6w8uOk/xSQPZVdP8J2DQBlDD2NX5Zjo1sg2dCP/f CMxQeIMKJqo3ejBCVdASUNkXY99JR2FpgI5bQ89k760= Original-Received: from mail.jurta.org (m91-129-103-27.cust.tele2.ee [91.129.103.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a71.g.dreamhost.com (Postfix) with ESMTPSA id 890CF7F5C3; Tue, 3 Mar 2020 16:10:41 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a71 In-Reply-To: (Dmitry Gutov's message of "Tue, 3 Mar 2020 13:27:18 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedruddtjedgudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrvdejpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176822 Archived-At: >> But the command has more unsolved issues: >> 1. command name - the most natural name would be vc-root-dir, >> but this name is already taken by a non-interactive function. > > vc-dir-quick was my idea. This name implies its implementation has better performance over its slower competitor. >> 2. keybinding - there are many contradicting proposals, >> and leaving it unbound is not the best solution. > > Like mentioned already, I think it's fine unbound. Not worse than having > a user option. It comes down to the user either customizing the option, > or binding the command to 'C-x v d' in their init script. We shouldn't > provide both in the core, though. > >>>> +(defcustom vc-dir-default-directory nil >>>> + "Default directory name for the command `vc-dir'. >>> >>> Both of these lines look wrong. >>> >>> VC-Dir already uses the correct directory as the default. What you're >>> looking for is to avoid prompting the user. >> These details are explained further down in the docstring: > > I'm saying both the option name and the first sentence of the docstring > don't fit its purpose, or the later description. This option is multi-purpose and one of its possible values is: When a string and `vc-dir' is invoked in a directory outside of version control, then this string is used as a default directory name.