From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] pcase.el: Add type pattern Date: Tue, 10 Mar 2020 14:19:46 -0500 Message-ID: <878sk881bh.fsf@alphapapa.net> References: <874kuxxuez.fsf@alphapapa.net> <87r1y1wcj4.fsf@alphapapa.net> <87h7yxw5x1.fsf@alphapapa.net> <87a74puq1q.fsf@web.de> <87d09lw3id.fsf@alphapapa.net> <87zhcoqmmz.fsf@web.de> <87wo7s8b73.fsf@alphapapa.net> <87eeu0qisn.fsf@web.de> <87o8t487mb.fsf@alphapapa.net> <871rq0qf5w.fsf@web.de> <87h7yw84sb.fsf@alphapapa.net> <87d09k8477.fsf@alphapapa.net> <87wo7sowpy.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="119761"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 10 20:21:04 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jBkR1-000Uxa-Iv for ged-emacs-devel@m.gmane-mx.org; Tue, 10 Mar 2020 20:20:59 +0100 Original-Received: from localhost ([::1]:39096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBkR0-00057d-Jz for ged-emacs-devel@m.gmane-mx.org; Tue, 10 Mar 2020 15:20:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43808) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBkQ0-0003Lm-Of for emacs-devel@gnu.org; Tue, 10 Mar 2020 15:19:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBkPz-0000Gw-Rn for emacs-devel@gnu.org; Tue, 10 Mar 2020 15:19:56 -0400 Original-Received: from ciao.gmane.io ([159.69.161.202]:56026) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBkPz-0000Cu-Lq for emacs-devel@gnu.org; Tue, 10 Mar 2020 15:19:55 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1jBkPw-000TYT-8i for emacs-devel@gnu.org; Tue, 10 Mar 2020 20:19:52 +0100 X-Injected-Via-Gmane: http://gmane.org/ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 159.69.161.202 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245444 Archived-At: Michael Heerdegen writes: > Adam Porter writes: > >> 1. Pull master and rebase my patch on it. > > I didn't try that. The last time you said you also evaluated the pcase > macro definition in *scratch*. That's what I did, in a master built > with your patch not applied. Anyway, I guess this doesn't matter > much... Right, I did that as well, and I got the same result as when I rebuilt Emacs with the patch applied. I can't explain why you got a different result. Well, at least this has been thoroughly tested now. :)