all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Juri Linkov <juri@linkov.net>
Cc: 40127@debbugs.gnu.org
Subject: bug#40127: 27.0.90; image-mode fails on all images with short EXIF tags
Date: Thu, 19 Mar 2020 16:19:35 +0100	[thread overview]
Message-ID: <878sjwwewo.fsf@gnus.org> (raw)
In-Reply-To: <87a74d2p4g.fsf@mail.linkov.net> (Juri Linkov's message of "Thu,  19 Mar 2020 01:57:03 +0200")

Juri Linkov <juri@linkov.net> writes:

> I realized that the 4th problem reported in bug#39994 is not related to
> image-converter.el, so here is a separate bug report.
>
> The problem is that currently image-mode fails to open all image files
> where one of EXIF tags is shorter than 4 bytes.  So none of the
> images created by a device whose EXIF tag "Manufacturer" is "HTC"
> can not be opened in Emacs 27.

OK, fixed now in Emacs 27.  (Well, I did the fix on the trunk and then
cherry-picked it...  I was slightly unsure whether to also include the
new test cases and files, but I did so anyway -- they won't affect the
release anyway, I think?)

> Here's is the patch that at least allows opening any image
> ignoring errors in EXIF parser implementation:

[...]

> -               (ignore-error exif-error
> +               (ignore-errors
>                   (exif-parse-buffer)))

No, we should never wallpaper over bugs in the code -- we should fix the
bugs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2020-03-19 15:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 23:57 bug#40127: 27.0.90; image-mode fails on all images with short EXIF tags Juri Linkov
2020-03-19 15:19 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sjwwewo.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=40127@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.