From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Michael Heerdegen <michael_heerdegen@web.de>, emacs-devel@gnu.org
Subject: Re: master c59e878: Inhibit modification hooks when saving eieio-persistent's
Date: Fri, 01 May 2020 17:03:26 -0700 [thread overview]
Message-ID: <878sib8apd.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <jwvh7wztlse.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 01 May 2020 17:01:39 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Inhibit modification hooks when saving eieio-persistent's
>>
>> * lisp/emacs-lisp/eieio-base.el (eieio-persistent-save): Bind
>> inhibit-modification-hooks -> t.
>
> I think this deserves an explanation (as a extensive comment explaining
> why it's needed and why we think it's safe to do it here.)
>
> Binding `inhibit-modification-hooks` is not as dangerous as binding
> `inhibit-quit` but it's something we should still avoid as much
> as possible.
I'm curious what the objection is -- why would we *want* modification
hooks to run when writing an eieio object out to file?
next prev parent reply other threads:[~2020-05-02 0:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200501192115.23847.67499@vcs0.savannah.gnu.org>
[not found] ` <20200501192116.A55EE20B5B@vcs0.savannah.gnu.org>
2020-05-01 21:01 ` master c59e878: Inhibit modification hooks when saving eieio-persistent's Stefan Monnier
2020-05-01 21:45 ` Michael Heerdegen
2020-05-01 22:03 ` Stefan Monnier
2020-05-01 22:24 ` Michael Heerdegen
2020-05-01 22:40 ` Stefan Monnier
2020-05-01 23:30 ` Michael Heerdegen
2020-05-02 13:26 ` Stefan Monnier
2020-05-02 21:08 ` Michael Heerdegen
2020-05-02 22:09 ` Stefan Monnier
2020-05-03 2:44 ` Michael Heerdegen
2020-05-03 4:01 ` Stefan Monnier
2020-05-03 5:13 ` Michael Heerdegen
2020-05-04 21:09 ` Eric Abrahamsen
2020-05-04 21:36 ` Michael Heerdegen
2020-05-04 21:42 ` Eric Abrahamsen
2020-05-02 4:24 ` Michael Heerdegen
2020-05-02 0:03 ` Eric Abrahamsen [this message]
2020-05-02 0:22 ` Michael Heerdegen
2020-05-02 13:32 ` Stefan Monnier
2020-05-02 18:18 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sib8apd.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.