From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Newsgroups: gmane.emacs.devel Subject: Re: project.el: git submodules? Date: Fri, 15 May 2020 09:40:40 +0200 Message-ID: <878shtlk7b.fsf@gmail.com> References: <875zd1ni5i.fsf@md5i.com> <55769244-c84c-dff0-4427-9ff688f81af5@yandex.ru> <87v9l0nar5.fsf@md5i.com> <95a8c285-125f-afda-b1bc-d1c0452e5c31@yandex.ru> <1bc2052e-b26b-1f3d-f78c-a22112861f27@yandex.ru> <7b247aac-28bd-94c1-2546-524edde9b781@yandex.ru> <42510ba9-1235-7180-af36-2d9de24835b4@yandex.ru> <21e149fc-dba5-47f0-ea7f-60a16ea32819@yandex.ru> <91b1284a-08d0-e57c-e6e3-c9a0a8e66e8b@yandex.ru> <6101fe38-2e28-83a1-0cad-a2d5bcd2df16@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="99226"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Welsh Duggan , Gary Oberbrunner , Stefan Monnier , Michael Welsh Duggan , "emacs-devel@gnu.org" To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 15 09:41:24 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZUyB-000PkV-OI for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 09:41:23 +0200 Original-Received: from localhost ([::1]:37996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZUyA-0001LJ-MQ for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 03:41:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZUxZ-0000na-LL for emacs-devel@gnu.org; Fri, 15 May 2020 03:40:45 -0400 Original-Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:55613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZUxY-0003bp-NC for emacs-devel@gnu.org; Fri, 15 May 2020 03:40:45 -0400 Original-Received: by mail-wm1-x32a.google.com with SMTP id f13so1247916wmc.5 for ; Fri, 15 May 2020 00:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=kT2kK7xRp9sr3k7g8xO6OdTqCBoeP+PEWPviQtRTKVk=; b=dloOcsDLmO8kcAFABvCfqg4dWuKoj3Jb8LIYolBcbfnuMjjASvOL9X/WGozUGZSlV1 DsvaNqNYwRw/oOm2zTDJH4CIchlnGW5/hjJuG6/7ibVT312TlILwNQhrB9wcPneXmmOO TbXiqJpus/jGaoRRWWWqsJqQGxB7QY9h/bkdo1wFpQrSUFigqdBF27p7rqbNqFTtFogM qNK6Lne8zfhYhVhkYB56rc1uZUc5ay6iybb4g6cBjpoK7nRWZZJdczqdT7+1h1OcBOg0 yB1ci6ZTWBJmBXsKRT3uOLvvhHtnT4aBktsEBl4rrwbZhs1vT3EJkdpjjCBAPJu1440C /ZwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=kT2kK7xRp9sr3k7g8xO6OdTqCBoeP+PEWPviQtRTKVk=; b=r5GRNszIQqwuZKKiaIgkXIlgyb/cipGRhlaRZkFAjI1QtnyvVLANVereuXVtwMHWkC xkWOxkNgkc2qzg/roblgsXO9ldd0DpR33Uu+4IpoOzORPLUSDzyZAvzOTrn0HPLn/VdM hxwtSPUdamAQ5ISeR921tzEpPrdS0mU3hoXn5Cbo5ppdqRZdTyzTZ4HY68+jnUbBPZX1 adRwB8gWQajbYn527WAowPrvWvqMW+WwbUKk4BXJFKCy/ZBKIkAlGJ8bsuGqFGOzEjUb cxQSoz28yeyh/ZHjH32pdtKWaNKxfwrf+B8JVnb3Hcp6JKAaItVhZdyaFX8kSWzfV3sq azmA== X-Gm-Message-State: AOAM5307DmH+cZlQ310ZPdyWV9luV8f7ALwxu4MQfJUk2Pg3bBTAapSz AyfNXy3+chrMKkCu4htpiCN7YaDes7ReCw== X-Google-Smtp-Source: ABdhPJyPt3DkFd7apORlii8fyFeE+4s63QoIPyziDvxySTX7d7KIibtu7Bcy+DN1XRn9d8t3Q3921Q== X-Received: by 2002:a1c:3c8b:: with SMTP id j133mr2646896wma.17.1589528442693; Fri, 15 May 2020 00:40:42 -0700 (PDT) Original-Received: from my-little-tumbleweed (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id z7sm2261634wrl.88.2020.05.15.00.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 00:40:41 -0700 (PDT) In-Reply-To: <6101fe38-2e28-83a1-0cad-a2d5bcd2df16@yandex.ru> (Dmitry Gutov's message of "Fri, 15 May 2020 08:11:24 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=kevin.legouguec@gmail.com; helo=mail-wm1-x32a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250360 Archived-At: Dmitry Gutov writes: > On 15.05.2020 04:21, Dmitry Gutov wrote: >> OK. >> Here's a patch you can try: >> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el >> index ac56537b97..bc79e7591b 100644 >> --- a/lisp/progmodes/project.el > > I've just pushed an improved version of this patch to master. > > And now that project.el is in ELPA, it should be updated soon as well > (look for version 0.1.1). I've tried commit 779bc886: =E2=9C=93 within "nested" projects (e.g. when $HOME is under version contro= l, and visiting the Emacs repo under ~/src/emacs), project-find-file uses the innermost project (~/src/emacs) as root, =E2=9C=93 at the root of a Git worktree (e.g. when ~/src/emacs-26.3 is a worktree of ~/src/emacs, and visiting ~/src/emacs-26.3), project-find-file uses the worktree (~/src/emacs-26.3) as root, =E2=9D=8C in a subfolder of a Git worktree (e.g. in ~/src/emacs-26.3/sr= c), project-find-file signals: > project-try-vc: Opening input file: No such file or directory, /home/$USE= R/src/emacs-26.3/src/.git =E2=9C=93 at the root of a Git submodule (e.g. when ~/projects/foo/bar is a submodule of ~/projects/foo, and visiting ~/projects/foo/bar), project-find-file uses the parent module (~/projects/foo) as root, =E2=9D=8C in a subfolder of a Git submodule (e.g. in ~/projects/foo/bar/baz), project-find-file signals: > project-try-vc: Opening input file: No such file or directory, /home/$USE= R/projects/foo/bar/baz/.git I hope I got that right. Thank you for working on this; I'd love for project-find-file to finally work in worktrees :)