From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41858: 28.0.50; [PATCH]: Make project-shell use universal argument Date: Tue, 16 Jun 2020 02:01:31 +0300 Organization: LINKOV.NET Message-ID: <878sgndivw.fsf@mail.linkov.net> References: <87tuzd33i3.fsf@thornhill.no> <874krdclk2.fsf@mail.linkov.net> <87ftaw3jqx.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="119819"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41858@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 16 02:03:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkz4L-000V1i-PW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Jun 2020 02:03:13 +0200 Original-Received: from localhost ([::1]:51214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkz4K-0007ju-K1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Jun 2020 20:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkz4A-0007jZ-B6 for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 20:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36144) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkz4A-000708-2n for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 20:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkz49-0007xK-U8 for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 20:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jun 2020 00:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41858-submit@debbugs.gnu.org id=B41858.159226578030569 (code B ref 41858); Tue, 16 Jun 2020 00:03:01 +0000 Original-Received: (at 41858) by debbugs.gnu.org; 16 Jun 2020 00:03:00 +0000 Original-Received: from localhost ([127.0.0.1]:47688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkz48-0007wz-0V for submit@debbugs.gnu.org; Mon, 15 Jun 2020 20:03:00 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:58791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkz45-0007wL-Bs for 41858@debbugs.gnu.org; Mon, 15 Jun 2020 20:02:57 -0400 X-Originating-IP: 91.129.108.6 Original-Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 4F37740007; Tue, 16 Jun 2020 00:02:49 +0000 (UTC) In-Reply-To: <87ftaw3jqx.fsf@thornhill.no> (Theodor Thornhill's message of "Mon, 15 Jun 2020 06:50:53 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182002 Archived-At: > How about we just add this behaviour instead of appending the > file-path? so we get the "" appended to the shell buffer names. > Then you can remove that line from init :) Thanks, I see you did exactly this in your new patch. >> Regarding the C-u argument, I don't know maybe someone might want >> to use it. But shouldn't the C-u argument of 'project-shell' be >> more compatible with the C-u argument of 'shell' in its behaviour? > > I kind of agree, though it seems like the original "project-shell" was > intended to be used only interactively. I kind of view it as a specialized > case of "shell", maybe as a sort of "shell-dwim" but only for a very > limited case. We are always free of course to add a normal shell buffer in > root, and use it non-interactively in code. > > However, I can add an "&optional buffer" argument to the code and do > like it's done in "shell". It just seems like it is complicating the > behaviour a little bit. What do you think? I agree there is no need to complicate "project-shell" with all idiosyncrasies of "shell". > I've attached another patch for you to look at, with only the easy > changes, awaiting some feedback on the other parts :) I see no more problems with your patch, it seems it covers the needs of most users, thanks.