From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#8484: 24.0.50; Dired problems with marking and hidden subdirs Date: Wed, 16 Sep 2020 13:36:04 +0200 Message-ID: <878sdarm1n.fsf@gnus.org> References: <87k4ez8yva.fsf@escher.fritz.box> <871rj4bjm7.fsf@gnus.org> <874knzosf6.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31708"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stephen Berman , 8484@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 16 13:38:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIVlK-00089c-Ok for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Sep 2020 13:38:10 +0200 Original-Received: from localhost ([::1]:34390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIVlJ-0005ON-Qd for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Sep 2020 07:38:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIVkF-00040t-KG for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2020 07:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50121) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIVkE-0006aE-4P for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2020 07:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIVkE-000442-2N for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2020 07:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Sep 2020 11:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8484 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 8484-submit@debbugs.gnu.org id=B8484.160025618315555 (code B ref 8484); Wed, 16 Sep 2020 11:37:02 +0000 Original-Received: (at 8484) by debbugs.gnu.org; 16 Sep 2020 11:36:23 +0000 Original-Received: from localhost ([127.0.0.1]:33425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIVjb-00042p-1e for submit@debbugs.gnu.org; Wed, 16 Sep 2020 07:36:23 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:57134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIVjZ-00042b-A2 for 8484@debbugs.gnu.org; Wed, 16 Sep 2020 07:36:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=el1SbyyvtmR2+bObjKEhRof1i5eUMgxZ1Sz0RLqV53g=; b=OOdkxasGwRkAXmRm4amWsk/kEM NcyFheBl0S3ApNDrt5i/0MH0/mhclM4qItf8ndhPhxoO755E+BKhif420LUkKHppRENV51gjZzupW dYFBgXc8u+ClU5pobyBN293tSkbJmDiC9rxQzkRUkAefYlEyLDRFiWXT3h+wKIgHRLn0=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIVjK-0004FE-IJ; Wed, 16 Sep 2020 13:36:13 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAQAAAAB/ecQqAAAABGdBTUEAALGPC/xhBQAAAAJi S0dEAAHdihOkAAAACXBIWXMAAA7DAAAOwwHHb6hkAAAAB3RJTUUH5AkQCyMGR5f7bwAAABBJREFU GNNj+A8GDKMUdSgAT1Qe8M8TmhgAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDktMTZUMTE6MzU6 MDUrMDA6MDBrguOZAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA5LTE2VDExOjM1OjA1KzAwOjAw Gt9bJQAAAABJRU5ErkJggg== X-Now-Playing: Saito Koji's _433-1_: "433_067" In-Reply-To: <874knzosf6.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 15 Sep 2020 21:04:12 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188164 Archived-At: Juri Linkov writes: >> Stephen's patch seems to fix that example, so I've now applied it to the >> trunk. I had to move some utility functions from dired-aux to avoid >> dired.el unconditionally loading dired-aux always (since this change is >> in a very fundamental dired function). > > Ouch, this broke my configuration. When the init file contains: > > (add-hook 'dired-mode-hook 'dired-sort-toggle) > > trying to visit a Dired buffer fails with: > > Debugger entered--Lisp error: (error "No subdir-alist in tmp") > signal(error ("No subdir-alist in tmp")) > error("No subdir-alist in %s" #) > dired-current-directory() > dired-get-filename(nil t) It looks like that function can't be called before a dired function is properly set up, but dired-sort-toggle does so. I've now made dired-get-filename more robust again after the previous change to that function. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no