From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: No Wayman Newsgroups: gmane.emacs.bugs Subject: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction Date: Thu, 17 Sep 2020 12:24:20 -0400 Message-ID: <878sd82wy3.fsf@gmail.com> References: <87363g8krw.fsf@gmail.com> <87d02k2xvf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18146"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.5.5; emacs 28.0.50 Cc: 43467@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 18:26:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIwjh-0004cR-MX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 18:26:17 +0200 Original-Received: from localhost ([::1]:57052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIwjg-0005Ps-L4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 12:26:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIwiU-0004V1-Oy for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 12:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIwiU-0008Ln-Au for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 12:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIwiU-0005qh-12 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 12:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: No Wayman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 16:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43467 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43467-submit@debbugs.gnu.org id=B43467.160035986922433 (code B ref 43467); Thu, 17 Sep 2020 16:25:01 +0000 Original-Received: (at 43467) by debbugs.gnu.org; 17 Sep 2020 16:24:29 +0000 Original-Received: from localhost ([127.0.0.1]:38820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwhx-0005pl-C3 for submit@debbugs.gnu.org; Thu, 17 Sep 2020 12:24:29 -0400 Original-Received: from mail-qk1-f172.google.com ([209.85.222.172]:41465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwhv-0005pW-UK for 43467@debbugs.gnu.org; Thu, 17 Sep 2020 12:24:28 -0400 Original-Received: by mail-qk1-f172.google.com with SMTP id g72so2815098qke.8 for <43467@debbugs.gnu.org>; Thu, 17 Sep 2020 09:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=qKwLrV5gXQ6NqNhhvo1TZRG19rRrJV3JbAmhSDCkydA=; b=WA0e6RjNt6MAurr7U7C7+ZGGu0Gh/o5IJ9U8wyG/bbfW43Xs4NC/kk4tvw29AYcj4p 9KtiMQKYwbiysVP9mFAuY9EeDlflm04kesSmN9V9EJ75SAQv1o9bPWvUl3FLT/0f/rxc Qj+0UgMbLdSsSq0FixlCpPbj8cOU8hBfF6PRjdsnIXCW/qyTYt/GgrcDiyyfnzbpjmd4 PmYatO7SfppXuraMvegDVIT4HD5IJSkADlwqN2JCp6V1raEc7X64HXRWSoKM/TEOsUrx hACk4HeZK1hRPSDqWfp0o3CjCDXFHup27NIGLLzfHWa/V/ikxt/ZldepnnjnwEkODbi5 plIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=qKwLrV5gXQ6NqNhhvo1TZRG19rRrJV3JbAmhSDCkydA=; b=pQSYnbriT0IeiEOmLgfV2My2fCM8DhQXofmNN4HQZcLETR6wOun/cyaf3ITbh6ZM6Z MytiCA+y89fP2F76BUEmNiOURkMZ//CUGDIP/6sFEI4M7Gao1KcTjANwo+p5irE0fZnn ASoOJeEuVq+u7NCzR/2Y+9MWyh45mfIxV2OyFe4Mhz1v8uVpFByRJAbpQYzZlbE6ly1d Z2bPMaJbC32tTg35BSVUica2DRQryiEVFMpYGON8mG545ns5wQ77HG4aA4PeMx3xyayW 0pobaPYABFhuDkdXmx/riok6QxOgiFPFhqB8WHmJiLRdOyqEhK55R0+Ji+gJgHUJTVXk OCig== X-Gm-Message-State: AOAM530SRs+mquz7XtNCjrjuPG67y1LJjohACgI4dI5ryawNPMDHRY04 K8dYsxpswFNL5dVEOX0myufyhy//qyEZ8A== X-Google-Smtp-Source: ABdhPJwwh/Vr1YQyLX35SiPiD0hfPQ2XtYY+lQyGfpDqFOMtWB/KWotdEyA2drYXkZM5kzZHhlj4/w== X-Received: by 2002:a05:620a:1583:: with SMTP id d3mr28033467qkk.495.1600359862150; Thu, 17 Sep 2020 09:24:22 -0700 (PDT) Original-Received: from arch ([2601:8b:c300:1024:1266:d0ff:1635:f964]) by smtp.gmail.com with ESMTPSA id v131sm194566qkb.15.2020.09.17.09.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 09:24:20 -0700 (PDT) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188224 Archived-At: --=-=-= Content-Type: text/plain; format=flowed Robert Pluim writes: > Your defcustom needs a :version "28.1" Thanks, Robert. Addressed in attached patch. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-warning-show-suppression-buttons-take-three.patch Content-Description: take three >From 6160b555d4155141646c9064e59a41895c11e665 Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Thu, 17 Sep 2020 11:40:41 -0400 Subject: [PATCH] Allow customization of warning suppression button display * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons): new defcustom to disable/enable display of warning suppression buttons in *Warnings* buffer. --- lisp/emacs-lisp/warnings.el | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el index e10c149d89..5a8152d2dc 100644 --- a/lisp/emacs-lisp/warnings.el +++ b/lisp/emacs-lisp/warnings.el @@ -116,6 +116,12 @@ warning-suppress-types See also `warning-suppress-log-types'." :type '(repeat (repeat symbol)) :version "22.1") + +(defcustom warning-show-suppression-buttons t + "Whether or not to show suppresion buttons in the *Warnings* buffer. +If t, buttons are shown, else they are not." + :type 'boolean + :version "28.1") ;; The autoload cookie is so that programs can bind this variable ;; safely, testing the existing value, before they call one of the @@ -294,7 +300,7 @@ display-warning message) ;; Don't output the buttons when doing batch compilation ;; and similar. - (unless noninteractive + (unless (or noninteractive (not warning-show-suppression-buttons)) (insert " ") (insert-button "Disable showing" 'type 'warning-suppress-warning -- 2.28.0 --=-=-=--