From: No Wayman <iarchivedmywholelife@gmail.com>
To: Robert Pluim <rpluim@gmail.com>
Cc: 43467@debbugs.gnu.org
Subject: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction
Date: Thu, 17 Sep 2020 12:24:20 -0400 [thread overview]
Message-ID: <878sd82wy3.fsf@gmail.com> (raw)
In-Reply-To: <m2363g5qka.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 129 bytes --]
Robert Pluim <rpluim@gmail.com> writes:
> Your defcustom needs a :version "28.1"
Thanks, Robert. Addressed in attached patch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: take three --]
[-- Type: text/x-patch, Size: 1586 bytes --]
From 6160b555d4155141646c9064e59a41895c11e665 Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer <iarchivedmywholelife@gmail.com>
Date: Thu, 17 Sep 2020 11:40:41 -0400
Subject: [PATCH] Allow customization of warning suppression button display
* lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons):
new defcustom to disable/enable display of warning suppression buttons
in *Warnings* buffer.
---
lisp/emacs-lisp/warnings.el | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el
index e10c149d89..5a8152d2dc 100644
--- a/lisp/emacs-lisp/warnings.el
+++ b/lisp/emacs-lisp/warnings.el
@@ -116,6 +116,12 @@ warning-suppress-types
See also `warning-suppress-log-types'."
:type '(repeat (repeat symbol))
:version "22.1")
+
+(defcustom warning-show-suppression-buttons t
+ "Whether or not to show suppresion buttons in the *Warnings* buffer.
+If t, buttons are shown, else they are not."
+ :type 'boolean
+ :version "28.1")
\f
;; The autoload cookie is so that programs can bind this variable
;; safely, testing the existing value, before they call one of the
@@ -294,7 +300,7 @@ display-warning
message)
;; Don't output the buttons when doing batch compilation
;; and similar.
- (unless noninteractive
+ (unless (or noninteractive (not warning-show-suppression-buttons))
(insert " ")
(insert-button "Disable showing"
'type 'warning-suppress-warning
--
2.28.0
next prev parent reply other threads:[~2020-09-17 16:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 15:52 bug#43467: 28.0.50; [PATCH] defcustom warning-show-suppression-buttons No Wayman
2020-09-17 16:04 ` bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction No Wayman
2020-09-17 16:13 ` Robert Pluim
2020-09-17 16:24 ` No Wayman [this message]
2020-09-17 16:16 ` Lars Ingebrigtsen
2020-09-17 17:09 ` No Wayman
2020-09-17 17:27 ` Lars Ingebrigtsen
2020-09-17 18:08 ` No Wayman
2020-09-18 13:14 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sd82wy3.fsf@gmail.com \
--to=iarchivedmywholelife@gmail.com \
--cc=43467@debbugs.gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.