From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#10773: set-variable can't change values of user options Date: Sat, 19 Sep 2020 17:21:53 +0200 Message-ID: <878sd5pzam.fsf@gnus.org> References: <87r4y4fik0.fsf@mail.jurta.org> <5w1uq3lv3z.fsf@fencepost.gnu.org> <87sjijt2jv.fsf@mail.jurta.org> <64pqdm4mtn.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12243"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Glenn Morris , 10773@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 19 17:23:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJehi-00034N-Tk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 17:23:10 +0200 Original-Received: from localhost ([::1]:53400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJehh-0003uz-QL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 11:23:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJehb-0003uk-7N for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 11:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJeha-0001wk-MI for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 11:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJeha-0000Zf-Gy for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 11:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Sep 2020 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10773 X-GNU-PR-Package: emacs Original-Received: via spool by 10773-submit@debbugs.gnu.org id=B10773.16005289282112 (code B ref 10773); Sat, 19 Sep 2020 15:23:02 +0000 Original-Received: (at 10773) by debbugs.gnu.org; 19 Sep 2020 15:22:08 +0000 Original-Received: from localhost ([127.0.0.1]:47803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJegi-0000Xz-5S for submit@debbugs.gnu.org; Sat, 19 Sep 2020 11:22:08 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJegf-0000XM-Ik for 10773@debbugs.gnu.org; Sat, 19 Sep 2020 11:22:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ImR2YzpgHzcOjDsYrH1SV30jKzQQMe+pzY3Z1sX8yvE=; b=m2MifHMgcLa/a2t4fWjLwbi2So MfDMmDCALvGBxTDM0vdKjEGm9prhnc6NXDssacPk0mwar3PiYeo/ceFQUjJPTRk+gV+kw3EnV5aVs 4j/FzN0z4wD3JMQsW6pVYPxZ0BZsCwiHLiSy+cQlq3Drr9s3zLRFG2yGXGlcumCoBZDE=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJegV-0006XD-T3; Sat, 19 Sep 2020 17:21:58 +0200 X-Now-Playing: Propaganda's _A Secret Wish (2)_: "(Echo Of) Frozen Faces" In-Reply-To: (Stefan Monnier's message of "Sat, 11 Feb 2012 23:34:15 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188397 Archived-At: Stefan Monnier writes: >> But I think that has been previously rejected. > > That was a long time ago. We should do it for 24.2. Reintroducing defvars for define-minor-mode hook variables was done the following year: commit 7f17cc40ef9120ba1b1715399432f26e8850505a Author: Stefan Monnier AuthorDate: Mon May 27 12:12:52 2013 -0400 Always defvar a mode's hook and provide a docstring. * lisp/emacs-lisp/easy-mmode.el (define-minor-mode): * lisp/emacs-lisp/derived.el (define-derived-mode): Always defvar the mode hook and provide a docstring. There's still the question of using allowing these variables to be customized, and that still doesn't work: (customize-variable 'flyspell-mode-hook) -> "NO CUSTOMIZATION DATA; not intended to be customized." But... why not? So I've now added the patch below to Emacs 28. diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el index e3eb9294ed..fdc1233540 100644 --- a/lisp/emacs-lisp/easy-mmode.el +++ b/lisp/emacs-lisp/easy-mmode.el @@ -335,6 +335,9 @@ define-minor-mode No problems result if this variable is not bound. `add-hook' automatically binds it. (This is true for all hook variables.)" modefun))) + ;; Allow using using `M-x customize-variable' on the hook. + (put ',hook 'custom-type 'hook) + (put ',hook 'standard-value (list nil)) ;; Define the minor-mode keymap. ,(unless (symbolp keymap) ;nil is also a symbol. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no