From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Fri, 11 Dec 2020 18:05:01 +0200 Message-ID: <878sa4ba6q.fsf@protesilaos.com> References: <87im9fgm27.fsf@protesilaos.com> <87zh2ozer4.fsf@tcd.ie> <87ft4edret.fsf@protesilaos.com> <87zh2ldgtf.fsf@protesilaos.com> <87k0toof83.fsf@mail.linkov.net> <83wnxo1mcr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25003"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: contovob@tcd.ie, 45068@debbugs.gnu.org, juri@linkov.net To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 11 17:10:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knkzq-0006No-Kw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 17:10:18 +0100 Original-Received: from localhost ([::1]:38710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knkzn-0001yy-NJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 11:10:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knkvi-0006Gj-HH for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 11:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knkvi-0004Dm-8T for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 11:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knkvi-0002uq-3J for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 11:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Dec 2020 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.160770271411147 (code B ref 45068); Fri, 11 Dec 2020 16:06:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 11 Dec 2020 16:05:14 +0000 Original-Received: from localhost ([127.0.0.1]:42734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knkuw-0002th-3A for submit@debbugs.gnu.org; Fri, 11 Dec 2020 11:05:14 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:25289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knkut-0002tS-Oe for 45068@debbugs.gnu.org; Fri, 11 Dec 2020 11:05:12 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 8334124000B; Fri, 11 Dec 2020 16:05:04 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Fri, 11 Dec 2020 08:16:47 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195782 Archived-At: On 2020-12-11, 08:16 -0600, Stefan Kangas wrote: > Eli Zaretskii writes: > >>> Taking a step back, why are any themes in "etc/themes" to begin with? >> >> This question should have been asked 10 years ago, when we added that >> place. > > I wasn't paying attention 10 years ago, I'm afraid. :-) > >> Nowadays I think the question is what's so wrong with that >> place that would justify moving the files. If there are no serious >> problems, I'd prefer to keep using that directory for themes. > > Right. Well, I don't exactly have a strong opinion either way. But I > do think that we should be consistent: it would be confusing to have > some themes in "etc/themes" and some in "lisp/themes". > > If we can't move all themes to "lisp/themes" and we don't want to use > "lisp/themes" just for support files, to my mind the only remaining way > forward is to add some way to byte-compile (perhaps only some?) files in > "etc/themes". And then make sure they can be loaded, are installed with > Emacs, etc. > > Does that sound good, or could we do even better here? > > Protesilaos, what do you think? Does it sound workable for you? I am fine with whatever is considered best for Emacs and am willing to make any changes you may consider necessary. My intent here is to contribute the latest version which satisfies the number one feature request I kept receiving: let the themes be customised uniformly. -- Protesilaos Stavrou protesilaos.com