bug#45771: 28.0.50; GMP not showing in system-configuration-feature

bug#45771: 28.0.50; GMP not showing in system-configuration-feature

[Phillip Lord]

The string "GMP" is not showing in system-configuration-feature on Emacs
master branch, even when libgmp has been configured and is reported to
be in use by configure. Confirmed on builds on both Ubuntu and
Windows. This string does appear on builds from Emacs-27

As a slightly separate issue, this appears to be the only way of showing
that libgmp is available for use.

Phil

bug#45771: 28.0.50; GMP not showing in system-configuration-feature

[Eli Zaretskii]

> From: Phillip Lord <phillip.lord@russet.org.uk>
> Date: Sun, 10 Jan 2021 18:08:43 +0000
> 
> The string "GMP" is not showing in system-configuration-feature on Emacs
> master branch, even when libgmp has been configured and is reported to
> be in use by configure. Confirmed on builds on both Ubuntu and
> Windows.

I think this is because:

  for opt in XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO IMAGEMAGICK SOUND GPM DBUS \
    GCONF GSETTINGS GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT \
    LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS X_TOOLKIT OLDXMENU X11 XDBE XIM \
    NS MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER UNEXEC LCMS2 GMP; do

      case $opt in
	PDUMPER) val=${with_pdumper} ;;
	UNEXEC) val=${with_unexec} ;;
	GLIB) val=${emacs_cv_links_glib} ;;
	NOTIFY|ACL) eval val=\${${opt}_SUMMARY} ;;
	TOOLKIT_SCROLL_BARS|X_TOOLKIT) eval val=\${USE_$opt} ;;
	THREADS) val=${threads_enabled} ;;
	*) eval val=\${HAVE_$opt} ;;
      esac

but we set HAVE_GMP only afterwards:

  if test -z "$GMP_H"; then
    HAVE_GMP=yes
  else
    HAVE_GMP=no
  fi

We need to move the latter before the former.

> As a slightly separate issue, this appears to be the only way of showing
> that libgmp is available for use.

Yes, because if GMP is not available, we have a replacement.

bug#45771: 28.0.50; GMP not showing in system-configuration-feature

[Robert Pluim]

tags 45771 fixed
close 45771 28.1
quit

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Phillip Lord <phillip.lord@russet.org.uk>
>> Date: Sun, 10 Jan 2021 18:08:43 +0000
>> 
>> The string "GMP" is not showing in system-configuration-feature on Emacs
>> master branch, even when libgmp has been configured and is reported to
>> be in use by configure. Confirmed on builds on both Ubuntu and
>> Windows.
>
> I think this is because:
>
>   for opt in XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO IMAGEMAGICK SOUND GPM DBUS \
>     GCONF GSETTINGS GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT \
>     LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS X_TOOLKIT OLDXMENU X11 XDBE XIM \
>     NS MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER UNEXEC LCMS2 GMP; do
>
>       case $opt in
> 	PDUMPER) val=${with_pdumper} ;;
> 	UNEXEC) val=${with_unexec} ;;
> 	GLIB) val=${emacs_cv_links_glib} ;;
> 	NOTIFY|ACL) eval val=\${${opt}_SUMMARY} ;;
> 	TOOLKIT_SCROLL_BARS|X_TOOLKIT) eval val=\${USE_$opt} ;;
> 	THREADS) val=${threads_enabled} ;;
> 	*) eval val=\${HAVE_$opt} ;;
>       esac
>
> but we set HAVE_GMP only afterwards:
>
>   if test -z "$GMP_H"; then
>     HAVE_GMP=yes
>   else
>     HAVE_GMP=no
>   fi
>
> We need to move the latter before the former.
>

Done in 62e3750af3

Closing.

Robert

bug#45771: 28.0.50; GMP not showing in system-configuration-feature

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Phillip Lord <phillip.lord@russet.org.uk>,  45771@debbugs.gnu.org
> Date: Mon, 11 Jan 2021 13:28:31 +0100
> 
> >   if test -z "$GMP_H"; then
> >     HAVE_GMP=yes
> >   else
> >     HAVE_GMP=no
> >   fi
> >
> > We need to move the latter before the former.
> >
> 
> Done in 62e3750af3

Thanks!