* bug#46025: 28.0.50; warning suppression buttons truncate warnings
@ 2021-01-21 20:51 No Wayman
2021-01-22 9:12 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: No Wayman @ 2021-01-21 20:51 UTC (permalink / raw)
To: 46025
The warning suppression buttons introduced in
66d01012ba61a364fe92cdc1728bfa135a90626a truncate warning
messages.
I have offered a trivial patch in the past to have an option to
disable these buttons:
https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-09/msg01405.html
Lars did not see it as a valid use case. His argument
(summarized):
> since you get the warnings so seldom, it makes sense
> to have the very few you see come with ready-made ways of making
> them go
> away, and then you're back to no warnings again.
Initially I thought the idea of the buttons was useful, but after
thinking on it more
I agree with the case against these buttons Jonas Bernoulli made
here:
https://lists.gnu.org/archive/html/emacs-devel/2020-11/msg00768.html
I would add to that, the fact that the buttons truncate the
warning messages makes it impossible for a user to make an
informed decision on whether or not they should be suppressing the
warning. The truncated messages are equally useless to me as a
developer. Here's an image someone sent me of the warnings on
their system:
https://user-images.githubusercontent.com/2872862/105290265-42526580-5bb0-11eb-962d-b56f71b6efc0.png
While I politely encouraged them to send text in the future for
such output,
here's what I would've received:
Warning (comp): Debugger entered--Lisp error:
(native-compiler-error-empty-byte
"/root/.emacs.d/straight/build/straight/straight-au..."
"/root/.emacs.d/straight/build/straight/straight-au...\
") Disable showing Disable logging
Warning (comp): Debugger entered--Lisp error:
(native-compiler-error-empty-byte
"/root/.emacs.d/straight/build/bind-key/bind-key-au..."
"/root/.emacs.d/straight/build/bind-key/bind-key-au...\
") Disable showing Disable logging
Warning (comp): Debugger entered--Lisp error:
(native-compiler-error-empty-byte
"/root/.emacs.d/straight/build/use-package/use-pack..."
"/root/.emacs.d/straight/build/use-package/use-pack...\
") Disable showing Disable logging
It's only by luck I can see enough of the file path to know which
files are throwing the errors.
Is there a way to work around this (absent my patch)?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#46025: 28.0.50; warning suppression buttons truncate warnings
2021-01-21 20:51 bug#46025: 28.0.50; warning suppression buttons truncate warnings No Wayman
@ 2021-01-22 9:12 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-22 22:05 ` No Wayman
2021-04-21 3:19 ` Stefan Kangas
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-01-22 9:12 UTC (permalink / raw)
To: No Wayman; +Cc: 46025
No Wayman <iarchivedmywholelife@gmail.com> writes:
> The warning suppression buttons introduced in
> 66d01012ba61a364fe92cdc1728bfa135a90626a truncate warning messages.
> I have offered a trivial patch in the past to have an option to
> disable these buttons:
>
> https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-09/msg01405.html
>
> Lars did not see it as a valid use case. His argument (summarized):
>
>> since you get the warnings so seldom, it makes sense
>> to have the very few you see come with ready-made ways of making
>> them go
>> away, and then you're back to no warnings again.
>
> Initially I thought the idea of the buttons was useful, but after
> thinking on it more
> I agree with the case against these buttons Jonas Bernoulli made here:
>
> https://lists.gnu.org/archive/html/emacs-devel/2020-11/msg00768.html
>
> I would add to that, the fact that the buttons truncate the warning
> messages makes it impossible for a user to make an informed decision
> on whether or not they should be suppressing the warning. The
> truncated messages are equally useless to me as a developer. Here's an
> image someone sent me of the warnings on their system:
>
> https://user-images.githubusercontent.com/2872862/105290265-42526580-5bb0-11eb-962d-b56f71b6efc0.png
>
> While I politely encouraged them to send text in the future for such
> output,
> here's what I would've received:
>
> Warning (comp): Debugger entered--Lisp error:
> (native-compiler-error-empty-byte
> "/root/.emacs.d/straight/build/straight/straight-au..."
> "/root/.emacs.d/straight/build/straight/straight-au...\
> ") Disable showing Disable logging
> Warning (comp): Debugger entered--Lisp error:
> (native-compiler-error-empty-byte
> "/root/.emacs.d/straight/build/bind-key/bind-key-au..."
> "/root/.emacs.d/straight/build/bind-key/bind-key-au...\
> ") Disable showing Disable logging
> Warning (comp): Debugger entered--Lisp error:
> (native-compiler-error-empty-byte
> "/root/.emacs.d/straight/build/use-package/use-pack..."
> "/root/.emacs.d/straight/build/use-package/use-pack...\
> ") Disable showing Disable logging
>
> It's only by luck I can see enough of the file path to know which
> files are throwing the errors.
>
> Is there a way to work around this (absent my patch)?
Hi,
is using the full output in the *Async-native-compile-log* buffer an
acceptable alternative?
Regards
Andrea
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#46025: 28.0.50; warning suppression buttons truncate warnings
2021-01-22 9:12 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-01-22 22:05 ` No Wayman
0 siblings, 0 replies; 7+ messages in thread
From: No Wayman @ 2021-01-22 22:05 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 46025
Andrea Corallo <akrl@sdf.org> writes:
>
> Hi,
>
> is using the full output in the *Async-native-compile-log*
> buffer an
> acceptable alternative?
>
> Regards
>
> Andrea
Hi, Andrea.
That's a workaround for the time being and I appreciate the
advice.
Long term, I think Stefan's idea of educating users on the nature
of the
warnings and encouraging them to report them to package
maintainers seems like a
better solution than encouraging them to sweep warnings under the
rug.
~ Nick
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#46025: 28.0.50; warning suppression buttons truncate warnings
2021-01-21 20:51 bug#46025: 28.0.50; warning suppression buttons truncate warnings No Wayman
2021-01-22 9:12 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-04-21 3:19 ` Stefan Kangas
2021-04-21 8:58 ` Eli Zaretskii
2021-04-21 11:39 ` iarchivedmywholelife
2022-07-28 12:39 ` Lars Ingebrigtsen
3 siblings, 1 reply; 7+ messages in thread
From: Stefan Kangas @ 2021-04-21 3:19 UTC (permalink / raw)
To: No Wayman; +Cc: 46025
No Wayman <iarchivedmywholelife@gmail.com> writes:
> The warning suppression buttons introduced in
> 66d01012ba61a364fe92cdc1728bfa135a90626a truncate warning messages.
> I have offered a trivial patch in the past to have an option to disable these
> buttons:
>
> https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-09/msg01405.html
>
> Lars did not see it as a valid use case. His argument (summarized):
>
>> since you get the warnings so seldom, it makes sense
>> to have the very few you see come with ready-made ways of making them go
>> away, and then you're back to no warnings again.
>
> Initially I thought the idea of the buttons was useful, but after thinking on it
> more
> I agree with the case against these buttons Jonas Bernoulli made here:
>
> https://lists.gnu.org/archive/html/emacs-devel/2020-11/msg00768.html
>
> I would add to that, the fact that the buttons truncate the warning messages
> makes it impossible for a user to make an informed decision on whether or not
> they should be suppressing the warning. The truncated messages are equally
> useless to me as a developer. Here's an image someone sent me of the warnings on
> their system:
Yes, it seems useless to have these buttons in their current form.
Could we at least disable them until they are fixed to not truncate
warnings? They hide the contents of legitimate warnings.
> https://user-images.githubusercontent.com/2872862/105290265-42526580-5bb0-11eb-962d-b56f71b6efc0.png
>
> While I politely encouraged them to send text in the future for such output,
> here's what I would've received:
>
> Warning (comp): Debugger entered--Lisp error: (native-compiler-error-empty-byte
> "/root/.emacs.d/straight/build/straight/straight-au..."
> "/root/.emacs.d/straight/build/straight/straight-au...\
> ") Disable showing Disable logging
> Warning (comp): Debugger entered--Lisp error: (native-compiler-error-empty-byte
> "/root/.emacs.d/straight/build/bind-key/bind-key-au..."
> "/root/.emacs.d/straight/build/bind-key/bind-key-au...\
> ") Disable showing Disable logging
> Warning (comp): Debugger entered--Lisp error: (native-compiler-error-empty-byte
> "/root/.emacs.d/straight/build/use-package/use-pack..."
> "/root/.emacs.d/straight/build/use-package/use-pack...\
> ") Disable showing Disable logging
>
> It's only by luck I can see enough of the file path to know which files are
> throwing the errors.
>
> Is there a way to work around this (absent my patch)?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#46025: 28.0.50; warning suppression buttons truncate warnings
2021-04-21 3:19 ` Stefan Kangas
@ 2021-04-21 8:58 ` Eli Zaretskii
0 siblings, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2021-04-21 8:58 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 46025, iarchivedmywholelife
> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 20 Apr 2021 22:19:31 -0500
> Cc: 46025@debbugs.gnu.org
>
> Yes, it seems useless to have these buttons in their current form.
>
> Could we at least disable them until they are fixed to not truncate
> warnings? They hide the contents of legitimate warnings.
AFAIK, the warnings are only truncated when they are VERY long, as in
the case above, where they show the backtrace from the Lisp debugger.
Originally, there was a bug that would cause almost every message be
truncated, but that was fixed.
Not sure what to do with warnings that show backtraces.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#46025: 28.0.50; warning suppression buttons truncate warnings
2021-01-21 20:51 bug#46025: 28.0.50; warning suppression buttons truncate warnings No Wayman
2021-01-22 9:12 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-21 3:19 ` Stefan Kangas
@ 2021-04-21 11:39 ` iarchivedmywholelife
2022-07-28 12:39 ` Lars Ingebrigtsen
3 siblings, 0 replies; 7+ messages in thread
From: iarchivedmywholelife @ 2021-04-21 11:39 UTC (permalink / raw)
To: Eli Zaretskii, Stefan Kangas; +Cc: 46025
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
> Not sure what to do with warnings that show backtraces.Perhaps we could do something similar to what the backtrace buffer does. After a certain length, ellide the warning with the ellipses, but make the ellipses expandable so the whole message can be seen. We could, optionally include a command to expand all.
[-- Attachment #2: Type: text/html, Size: 543 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#46025: 28.0.50; warning suppression buttons truncate warnings
2021-01-21 20:51 bug#46025: 28.0.50; warning suppression buttons truncate warnings No Wayman
` (2 preceding siblings ...)
2021-04-21 11:39 ` iarchivedmywholelife
@ 2022-07-28 12:39 ` Lars Ingebrigtsen
3 siblings, 0 replies; 7+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-28 12:39 UTC (permalink / raw)
To: No Wayman; +Cc: 46025
No Wayman <iarchivedmywholelife@gmail.com> writes:
> The warning suppression buttons introduced in
> 66d01012ba61a364fe92cdc1728bfa135a90626a truncate warning messages.
I've now changed this to use less intrusive buttons in Emacs 29.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-07-28 12:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-21 20:51 bug#46025: 28.0.50; warning suppression buttons truncate warnings No Wayman
2021-01-22 9:12 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-22 22:05 ` No Wayman
2021-04-21 3:19 ` Stefan Kangas
2021-04-21 8:58 ` Eli Zaretskii
2021-04-21 11:39 ` iarchivedmywholelife
2022-07-28 12:39 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.