From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Gunnar Horrigmo <gnunar@stoffe-pro.net>
Cc: Thomas Fitzsimmons <fitzsim@fitzsim.org>, 46056@debbugs.gnu.org
Subject: bug#46056: hardcoded ~/.emacs.d in elpa package excorporate
Date: Sat, 23 Jan 2021 22:31:13 +0000 [thread overview]
Message-ID: <878s8jz3ny.fsf@tcd.ie> (raw)
In-Reply-To: <iv41rebzfl3.fsf@hot-rats.uio.no> (Gunnar Horrigmo's message of "Sat, 23 Jan 2021 19:13:44 +0100")
Gunnar Horrigmo <gnunar@stoffe-pro.net> writes:
> The `excorporate' package hardcodes its diary files to
> ~/.emacs.d/excorporate, instead of honoring user-emacs-directory.
Right. CCing Thomas, the package's maintainer.
> I've included a small fix:
>
> === begin diff ===
>
> diff --git a/excorporate-diary.el b/excorporate-diary.el
> index 833df3017c..b147bed42d 100644
> --- a/excorporate-diary.el
> +++ b/excorporate-diary.el
> @@ -76,13 +76,17 @@ respectively."
> #'exco-diary-icalendar--add-diary-entry-around))
>
> (defvar excorporate-diary-today-file
> - "~/.emacs.d/excorporate/diary-excorporate-today"
> + (concat
> + (file-name-as-directory user-emacs-directory)
> + "excorporate/diary-excorporate-today")
Rather than concatenating file names as strings, better to use
locate-user-emacs-file in this case (or expand-file-name in general).
See (info "(elisp) Standard File Names").
[...]
> Am I submitting this the right way?
Ideally the patch would include a ChangeLog-style commit message
referencing this bug number; see the guidelines in the CONTRIBUTE
file[1] at the top of the Emacs source tree. Otherwise looks fine :).
[1]: https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE
Thanks,
--
Basil
next prev parent reply other threads:[~2021-01-23 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 18:13 bug#46056: hardcoded ~/.emacs.d in elpa package excorporate Gunnar Horrigmo
2021-01-23 22:31 ` Basil L. Contovounesios [this message]
2021-01-24 2:45 ` Gunnar Horrigmo
2021-01-24 3:16 ` Thomas Fitzsimmons
2021-01-24 9:21 ` Michael Albinus
2021-01-24 17:34 ` Thomas Fitzsimmons
2021-01-24 17:40 ` Michael Albinus
2021-01-24 12:04 ` Basil L. Contovounesios
2021-01-24 12:48 ` Gunnar Horrigmo
2021-01-24 11:58 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s8jz3ny.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=46056@debbugs.gnu.org \
--cc=fitzsim@fitzsim.org \
--cc=gnunar@stoffe-pro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.