From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: Separating colour and positioning functioning Date: Mon, 08 Feb 2021 22:37:38 +0100 Message-ID: <878s7yp7fh.fsf@zoho.eu> References: Reply-To: Emanuel Berg Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20369"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:vgyY9oED9+dZlEPcWSGs+P/F1j0= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 09 00:50:43 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9GIl-0005Ch-Kp for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 00:50:43 +0100 Original-Received: from localhost ([::1]:53430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9GIk-0000VK-Lm for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 18:50:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9EEA-0007ew-QS for help-gnu-emacs@gnu.org; Mon, 08 Feb 2021 16:37:50 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:48822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9EE9-00042D-5G for help-gnu-emacs@gnu.org; Mon, 08 Feb 2021 16:37:50 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1l9EE3-0006Un-Nt for help-gnu-emacs@gnu.org; Mon, 08 Feb 2021 22:37:43 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:127667 Archived-At: Christopher Dimech wrote: > Have written a minor mode with part of the the code below > and want to modify tex-typeface-crucible so that the colour > scheme is enabled when the minor-mode is on. I got the following warnings from the byte compiler: Warning: defface for ‘colour-tex-cruc’ fails to specify containing group Warning: reference to free variable ‘crucible-supinf-enable’ Warning: reference to free variable ‘crucible-supinf-vshift’ Warning: reference to free variable ‘supinf-font-lock-cruc’ Style PO-lice: > (defface colour-tex-cruc US English is preferable, then it becomes consistent. The user shouldn't have think, "is the programmer a 'bloke' or a 'dude'?" ... > '( (default :inherit bold) > ( ((class color) (min-colors 88) (background light)) > :foreground "#FF0000" ) > ( ((class color) (min-colors 88) (background dark)) > :foreground "#FF0000") > (t :inherit font-lock-builtin-face) ) > "Typeface for tex keywords.") Avoid hard-coding the same data (88 and "#FF0000") repeatedly. Normally, the method is to use `let'. > (defun supinf-disable-cruc (beg end) > "Set typeface for text between BEG and END." > (font-lock-default-unfontify-region beg end) > (while (< beg end) > (let ((next (next-single-property-change beg 'display nil end)) > (prop (get-text-property beg 'display))) > (if (and (eq (car-safe prop) 'raise) `if' -> `while' > (member (car-safe (cdr prop)) crucible-supinf-vshift) > (null (cddr prop))) > (put-text-property beg next 'display nil)) > (setq beg next)))) This looks unorthodox but OK, I don't have a snappy answer what to do instead... > (defun tex-typeface-crucible () > "Font-lock setup for mathematical symbols." > (font-lock-flush (point-min) (point-max)) Is that the same as just (font-lock-flush) ? > (if crucible-supinf-enable > (progn > (font-lock-add-keywords nil crucible-tex-keywords t) > (font-lock-add-keywords nil supinf-font-lock-cruc t)) > (font-lock-remove-keywords nil crucible-tex-keywords) > (supinf-disable-cruc (point-min) (point-max))) > (font-lock-flush (point-min) (point-max))) Is that the same as ... same. -- underground experts united http://user.it.uu.se/~embe8573 https://dataswamp.org/~incal