all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: jakanakaevangeli <jakanakaevangeli@chiru.no>
To: 46414@debbugs.gnu.org
Subject: bug#46414: 27.1; remove-hook doesn't remove entries from hook--depth-alist
Date: Wed, 10 Feb 2021 00:56:14 +0100	[thread overview]
Message-ID: <878s7w94o1.fsf@miha-pc> (raw)

add-hook can add an entry to the hook symbol's hook--depth-alist
property and remove-hook doesn't remove it. This means that for each
call to eval-after-load, after-load-functions' hook--depth-alist gets a
new element when the feature is loaded, which can hinder performance.

This can also cause problems if your completing-read-function uses

    (minibuffer-with-setup-hook (:append generated-function-symbol)
      (read-from-minibuffer ...))

This will add a new element to minibuffer-setup-hook's the depth alist
for each completing-read session (such is the case when using
selectrum.el [1] completion function).

[1] https://github.com/raxod502/selectrum/





             reply	other threads:[~2021-02-09 23:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 23:56 jakanakaevangeli [this message]
2022-06-16 13:40 ` bug#46414: 27.1; remove-hook doesn't remove entries from hook--depth-alist Lars Ingebrigtsen
2022-06-16 14:18   ` jakanakaevangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s7w94o1.fsf@miha-pc \
    --to=jakanakaevangeli@chiru.no \
    --cc=46414@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.