all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Boruch Baum <boruch_baum@gmx.com>
Cc: 49043@debbugs.gnu.org
Subject: bug#49043: 27.1: ibuffer-toggle-filter-group [BUGFIX]
Date: Wed, 16 Jun 2021 10:19:23 +0200	[thread overview]
Message-ID: <878s3aql10.fsf@gnus.org> (raw)
In-Reply-To: <20210615201851.jwnjx23qptp3agp7@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 15 Jun 2021 16:18:51 -0400")

Boruch Baum <boruch_baum@gmx.com> writes:

> Oops. I misquoted the code (because I had submitted the report after I
> had made/tested/byte-compiled/over-writte my only local copy). If you look at the
> code on the gnu cgit instance, at line 1907, you'll see that it adds one
> to the line-end-position before passing the value the function
> delete-region.

Right -- so I guess the problem here is that the last line of the buffer
doesn't have a newline...  but skimming the code (I'm not super-familiar
with ibuffer), it seems like the final non-newline line is a summary
line and should be kept out of the sorting/filtering process?  (If
there's a "buffer line" without a newline, it'll mess up the display
after filtering.)

So I think that perhaps the bug is somewhere else, but it's hard to say
without a recipe that reproduces the bug.

Do you have a test case?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-06-16  8:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 15:52 bug#49043: 27.1: ibuffer-toggle-filter-group [BUGFIX] Boruch Baum
2021-06-15 16:15 ` Lars Ingebrigtsen
2021-06-15 20:18   ` Boruch Baum
2021-06-16  8:19     ` Lars Ingebrigtsen [this message]
2021-06-16  8:26       ` Boruch Baum
2021-06-16  8:51         ` Lars Ingebrigtsen
2021-06-16 12:04         ` Eli Zaretskii
2021-06-16 17:01           ` Boruch Baum
2021-06-16 17:10             ` Eli Zaretskii
2021-06-18 14:11       ` Stephen Berman
2021-06-19 12:06         ` Lars Ingebrigtsen
2021-06-19 12:12           ` Michael Albinus
2021-06-19 15:56         ` Michael Albinus
2021-06-19 19:56           ` Stephen Berman
2021-06-19 21:41           ` Stephen Berman
2021-06-20  8:12             ` Boruch Baum
2021-06-20 14:29               ` Michael Albinus
2021-06-21 12:25             ` Lars Ingebrigtsen
2021-06-15 16:20 ` Eli Zaretskii
2021-06-15 20:13   ` Boruch Baum
2021-06-15 20:39   ` Boruch Baum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s3aql10.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=49043@debbugs.gnu.org \
    --cc=boruch_baum@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.