From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#11883: 24.1.50; shell-mode doesn't colorize the prompt Date: Fri, 16 Jul 2021 01:06:53 +0200 Message-ID: <878s27dvn6.fsf_-_@gnus.org> References: <87a9z9ec3k.fsf@shorty.local.i-did-not-set--mail-host-address--so-tickle-me> <20121106111243.3b2d7965@fatty> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28980"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 11883@debbugs.gnu.org, Dima Kogan To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 16 01:08:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4ASx-0007Kd-Ar for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Jul 2021 01:08:27 +0200 Original-Received: from localhost ([::1]:54672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4ASw-0005H4-DM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Jul 2021 19:08:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4ASY-0005Fl-93 for bug-gnu-emacs@gnu.org; Thu, 15 Jul 2021 19:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m4ASY-0003p9-1n for bug-gnu-emacs@gnu.org; Thu, 15 Jul 2021 19:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m4ASX-0006dP-Tg for bug-gnu-emacs@gnu.org; Thu, 15 Jul 2021 19:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jul 2021 23:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11883 X-GNU-PR-Package: emacs Original-Received: via spool by 11883-submit@debbugs.gnu.org id=B11883.162639042925363 (code B ref 11883); Thu, 15 Jul 2021 23:08:01 +0000 Original-Received: (at 11883) by debbugs.gnu.org; 15 Jul 2021 23:07:09 +0000 Original-Received: from localhost ([127.0.0.1]:50021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4ARh-0006b0-DG for submit@debbugs.gnu.org; Thu, 15 Jul 2021 19:07:09 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4ARg-0006ag-0W for 11883@debbugs.gnu.org; Thu, 15 Jul 2021 19:07:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=USqc4YktzEKxcPUf8Fcp0KDYo4yTU/rSpYa+e83iLrY=; b=hjmxWanvor7FEy78THqHoWpZFw gmNhKXQDkJgEL0vAOYprhp2Jvk+BoXQvrUHvPFvjxBoJKNuR+pBiu/MItsUw4iphIYnzWXKOEi12V s1dLKzvUxqxWfvFXqsjlvIs/+dlkkvoaQrg/w+/KXdfC7SyPhnYBYIpxsLWvBTCcN4CI=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4ARR-0005t8-JY; Fri, 16 Jul 2021 01:06:56 +0200 X-Now-Playing: Colored Music's _Individual Beauty_: "Ambient Discotheque" In-Reply-To: (Stefan Monnier's message of "Fri, 09 Nov 2012 14:05:47 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210060 Archived-At: Stefan Monnier writes: > The behavior you see is due to the following: > - the prompt is highlighted with an overlay that uses > a comint-highlight-prompt face. > - "the prompt" is determined dynamically as "the last > non-line-terminated output of the process". > - the ansi-color escapes used to be applied using overlays but are now > applied using text-properties. > > When you use ansi escapes to color the prompt, you clearly have > a conflict with the comint-highlight-prompt face that is to be used for > the prompt. The following simple tweak seems to fix the reported issue: diff --git a/lisp/comint.el b/lisp/comint.el index 9e406614b9..3dfb269de4 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -2157,9 +2157,9 @@ comint-output-filter 'comint-highlight-prompt)) (setq comint-last-prompt (cons (copy-marker prompt-start) (point-marker))) - (font-lock-prepend-text-property prompt-start (point) - 'font-lock-face - 'comint-highlight-prompt) + (font-lock-append-text-property prompt-start (point) + 'font-lock-face + 'comint-highlight-prompt) (add-text-properties prompt-start (point) `(rear-nonsticky ,comint--prompt-rear-nonsticky))) That is, we don't overwrite the ANSI face properties. I guess this might also avoid overwriting properties in prompts that use ANSI codes? Which might also be nice. Would this regress anything? Anybody got an opinion? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no