From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 12299@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
Roland Winkler <winkler@gnu.org>
Subject: bug#12299: 24.1; no byte compiler warning for inline function call with too few arguments [PATCH]
Date: Fri, 23 Jul 2021 13:09:46 +0200 [thread overview]
Message-ID: <878s1xffr9.fsf@gnus.org> (raw)
In-Reply-To: <743DF3D0-DA0F-49D4-A780-02C698AE8EFB@acm.org> ("Mattias Engdegård"'s message of "Thu, 22 Jul 2021 15:14:55 +0200")
Mattias Engdegård <mattiase@acm.org> writes:
> Would this patch do?
> For some reason that I haven't investigated, the usual
> warning-suppression mechanisms seem ineffective for these
> warnings. I'm probably doing something wrong. Even so, it's better to
> have arity checks that cannot be disabled than none at all.
Yes, we can fix up suppression afterwards...
> From cb9d873871eb445ad18b2a89f3c4ba7e6a4d3ef3 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Mattias=20Engdeg=C3=A5rd?= <mattiase@acm.org>
> Date: Thu, 22 Jul 2021 15:00:17 +0200
> Subject: [PATCH] Warn about arity errors in inlining calls (bug#12299)
This leads to warnings like:
Warning: Eager macro-expansion skipped due to cycle:
… => (load "byte-opt.el") => (macroexpand-all (defalias 'byte-decompile-bytecode-1 …)) => (macroexpand (cl-symbol-macrolet …)) => (load "byte-opt.el")
At least initially? A "make bootstrap" made it go away.
It otherwise seems to work fine for the test example.
I wondered whether this added warning would find errors in the Emacs
tree, so I did a "make bootstrap" after applying the patch, but we
apparently have none of those, which surprised me.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-07-23 11:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 2:14 bug#12299: 24.1; no byte compiler warning for inline function call with too few arguments Roland Winkler
2019-08-16 22:46 ` Lars Ingebrigtsen
2021-07-15 20:29 ` Lars Ingebrigtsen
2021-07-16 15:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-17 14:04 ` Lars Ingebrigtsen
2021-07-22 13:14 ` bug#12299: 24.1; no byte compiler warning for inline function call with too few arguments [PATCH] Mattias Engdegård
2021-07-23 11:09 ` Lars Ingebrigtsen [this message]
2021-07-23 13:18 ` Mattias Engdegård
2021-12-06 23:36 ` bug#12299: 24.1; no byte compiler warning for inline function call with too few arguments Stefan Kangas
2021-07-23 15:02 ` bug#12299: 24.1; no byte compiler warning for inline function call with too few arguments [PATCH] Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-23 15:52 ` Mattias Engdegård
2021-07-23 16:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s1xffr9.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=12299@debbugs.gnu.org \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.