From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41343: tab-bar-mode: Close tab on mouse-2 click Date: Tue, 14 Sep 2021 09:43:06 +0300 Organization: LINKOV.NET Message-ID: <878rzzu079.fsf@mail.linkov.net> References: <87wnp2cg52.fsf@linkov.net> <83tuk5la2u.fsf@gnu.org> <877dh18lj3.fsf@mail.linkov.net> <83y29gjvjh.fsf@gnu.org> <8735rn8jz6.fsf@mail.linkov.net> <83sfznhywm.fsf@gnu.org> <87tuk356ia.fsf@mail.linkov.net> <83im0iiw8n.fsf@gnu.org> <877dgvkt1z.fsf@mail.linkov.net> <83wnotfpak.fsf@gnu.org> <87k0ksecbq.fsf@mail.linkov.net> <83v94cdwk5.fsf@gnu.org> <87a6lepqqo.fsf@mail.linkov.net> <87mtorrlf5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4937"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41343@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 14 08:45:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQ2CK-00016T-VM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 08:45:40 +0200 Original-Received: from localhost ([::1]:49086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ2CJ-0002Kx-6E for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 02:45:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ2Bj-0002KX-Cs for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 02:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQ2Bi-0000Ay-JP for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 02:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQ2Bi-00076E-Gz for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 02:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Sep 2021 06:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41343-submit@debbugs.gnu.org id=B41343.163160184827207 (code B ref 41343); Tue, 14 Sep 2021 06:45:02 +0000 Original-Received: (at 41343) by debbugs.gnu.org; 14 Sep 2021 06:44:08 +0000 Original-Received: from localhost ([127.0.0.1]:47356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ2Aq-00074k-As for submit@debbugs.gnu.org; Tue, 14 Sep 2021 02:44:08 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:38437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ2Ao-00073m-91; Tue, 14 Sep 2021 02:44:06 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 703F0240008; Tue, 14 Sep 2021 06:43:57 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Mon, 6 Sep 2021 21:40:11 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214278 Archived-At: tags 41343 fixed close 41343 28.0.50 thanks >> Now the branch 'feature/tab-bar-events' is ready for testing. >> Please help to find any possible problems. > > I have tested it on GNU/Linux and macOS, and it seems to work fine. > > One concern is that tabs close on mouse down, rather than release. > > In Firefox, tabs close instead on mouse release. This is good, > because it gives me a second to react and move the mouse cursor away > in case I misclick. > > This is currently less important in Emacs, as the buffer survives even > such a misclick. But maybe in the future users will want tabs to be > more strongly connected to their associated buffers, and work would > then easily be lost to a misclick. > > Could we change this to close on mouse release instead? Thanks for the suggestion. It was trivially easy to implement this with the new design of the event handling on the tab bar.