From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Path & Demo: Source View in Help Buffers Date: Wed, 22 Sep 2021 16:08:36 +0200 Message-ID: <878rzo1ypa.fsf@gnu.org> References: <87o88kj2oz.fsf@gnu.org> <87k0j8j0v3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14459"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.6; emacs 28.0.50 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 22 16:19:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mT35W-0003Xt-Mj for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 16:19:06 +0200 Original-Received: from localhost ([::1]:38628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT35V-0005ow-FD for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 10:19:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT34P-00052U-39 for emacs-devel@gnu.org; Wed, 22 Sep 2021 10:17:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36544) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT34O-0007h6-Rh for emacs-devel@gnu.org; Wed, 22 Sep 2021 10:17:56 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:42627) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT34O-0002rY-OF for emacs-devel@gnu.org; Wed, 22 Sep 2021 10:17:56 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailauth.nyi.internal (Postfix) with ESMTP id 3A23A27C005B for ; Wed, 22 Sep 2021 10:17:56 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 22 Sep 2021 10:17:56 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeijedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpehffgfhvffuffgjkfggtgesthdtre dttdertdenucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhsughhsehgnhhurdho rhhgqeenucggtffrrghtthgvrhhnpeevveeikeetkeeviefgfeffiedvteeguddvffeuue duveegtddthedvhfeuveffhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhith ihqdekieejfeekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgsehfrghs thhmrghilhdrfhhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 22 Sep 2021 10:17:55 -0400 (EDT) In-reply-to: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275318 Archived-At: Arthur Miller writes: >> I think that's a common check for 3rd-party packages which want to keep >> supporting emacs 24. But since you are hacking emacs core, there's no >> need for that unless the function/variable is only defined if some >> configure option is given or some lib is available. But none of the >> latter applies to font-lock.el. > > Yes, I have tested now, it works fine. I did even som minor > refactoring. > > Don't know if anyone else cares at all, I don't know either. :-) > anyway here is updated patch. --8<---------------cut here---------------start------------->8--- +(defun help--insert-source () + "Fnd and insert source for the current symbol into the help-mode +buffer." --8<---------------cut here---------------end--------------->8--- Nitpick: There's an "i" missing in "F[i]nd" and checkdoc wants the first sentence on the first line. Aside from that, I think it would be useful if one could jump from the shown inlined code into the source file, too. Then one doesn't have to navigate back to the filename.{c,el} link. Maybe it could even jump to the line corresponding to the location of point in the inlined code? At least the lines offset is easy to calculate. Bye, Tassilo