all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: Path & Demo: Source View in Help Buffers
Date: Wed, 22 Sep 2021 16:08:36 +0200	[thread overview]
Message-ID: <878rzo1ypa.fsf@gnu.org> (raw)
In-Reply-To: <DB9PR09MB498669AD1D02349BD1C5CCC096A29@DB9PR09MB4986.eurprd09.prod.outlook.com>

Arthur Miller <arthur.miller@live.com> writes:

>> I think that's a common check for 3rd-party packages which want to keep
>> supporting emacs 24.  But since you are hacking emacs core, there's no
>> need for that unless the function/variable is only defined if some
>> configure option is given or some lib is available.  But none of the
>> latter applies to font-lock.el.
>
> Yes, I have tested now, it works fine. I did even som minor
> refactoring.
>
> Don't know if anyone else cares at all,

I don't know either. :-)

> anyway here is updated patch.

--8<---------------cut here---------------start------------->8---
+(defun help--insert-source ()
+  "Fnd and insert source for the current symbol into the help-mode
+buffer."
--8<---------------cut here---------------end--------------->8---

Nitpick: There's an "i" missing in "F[i]nd" and checkdoc wants the first
sentence on the first line.

Aside from that, I think it would be useful if one could jump from the
shown inlined code into the source file, too.  Then one doesn't have to
navigate back to the filename.{c,el} link.  Maybe it could even jump to
the line corresponding to the location of point in the inlined code?  At
least the lines offset is easy to calculate.

Bye,
Tassilo



  reply	other threads:[~2021-09-22 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22  8:59 Path & Demo: Source View in Help Buffers Arthur Miller
2021-09-22 10:55 ` Tassilo Horn
2021-09-22 11:06   ` Arthur Miller
2021-09-22 11:32     ` Tassilo Horn
2021-09-22 12:01       ` Arthur Miller
2021-09-22 13:42       ` Arthur Miller
2021-09-22 14:08         ` Tassilo Horn [this message]
2021-09-22 16:50           ` Arthur Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rzo1ypa.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.