From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Indentation of def* Date: Thu, 14 Oct 2021 01:13:10 +0200 Message-ID: <878ryw1ptl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4266"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 14 01:14:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1manRz-0000s8-Cw for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Oct 2021 01:14:19 +0200 Original-Received: from localhost ([::1]:45470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1manRx-0005ol-SI for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 19:14:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1manR5-000573-26 for emacs-devel@gnu.org; Wed, 13 Oct 2021 19:13:23 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:46834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1manR2-00017P-M4 for emacs-devel@gnu.org; Wed, 13 Oct 2021 19:13:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yltxDFr2B6FGCb4NN/riJ3gsdOcrv7Xjwnla6gSkaP0=; b=V2jUzKywWKMBdOxqfDMFBtIXsf jtKM6kEvAIkRAJI5UjrSxJqJ5jh2HYNPiK5RSpZHdRrF1qNGc5oF+GT2+BbNumzFIZFOK6aVxu4p1 q2CvAU/ilwNqqw/aaKrnW2OP8sYFGdJ01Y1TWIIEqGiKg49iNn4FDYHWkk3G9OnqJQ64=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1manQw-0004Pt-J0 for emacs-devel@gnu.org; Thu, 14 Oct 2021 01:13:17 +0200 X-Now-Playing: D-Day's _Somewhere Between: Mutant Pop, Electronic Minimalism & Shadow Sounds of Japan 1980-1988_: "Sweet Sultan" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276948 Archived-At: A longstanding issue is whether to do anything about this heuristic in our indentation code: (defun definitely-regular (a b)) (defun still-regular (a b)) (progn (definitely-regular a b) (still-regular a b)) That is, any function or macro that has a name that starts with "def" is indented similarly to a `defun' (etc). This is discussed in bug#43329, and all two of us discussing this have landed on "let's fix this". So today I've tagged all in-tree def* function/macros with correct indentation (ahem), so if we remove the heuristic from the indentation function, in-tree code won't change how it's indented. (By and large -- there's a handful of functions that will change, but the affected call sites should be less than a dozen, if I got it right.) But code that uses out-of-tree functions named def* will see indentation changes until everybody tags up their functions with (defun define-whatever () (declare (indent defun)) And people going back and forth between Emacs 29 and earlier versions will see the indentation change (for untagged functions), which is why we rarely change how Emacs Lisp is indented. So this is the thread where you can say "yay" or "eek". -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no