test-org/auto-repeat-maybe depends on locale

test-org/auto-repeat-maybe depends on locale

[Axel Kielhorn]

Hello,

I have just installed Org mode 9.5 and get a few failing tests:

Which LANG = de_DE.UTF-8 I get:

4 unexpected results:
   FAILED  ob-sed-test/cmd-line-header-argument
   FAILED  ob-shell/bash-uses-assoc-arrays
   FAILED  test-org-table/sort-lines
   FAILED  test-org/auto-repeat-maybe


But which LANG = C I get:

3 unexpected results:
   FAILED  ob-sed-test/cmd-line-header-argument
   FAILED  ob-shell/bash-uses-assoc-arrays
   FAILED  test-org-table/sort-lines

The result of test-org/auto-repeat-maybe depends on the locale used.

I’m using emacs 27.1 on MacOS 10.13 in case that matters.

(I actually expected test-org-table/sort-lines to depend on LANG, that’s why I tried with C)

I attached both fails.

Greetings 
Axel

Test test-org-table/sort-lines backtrace:
  signal(ert-test-failed (((should (equal "| a | x |\n| B | 4 |\n| c |
  ert-fail(((should (equal "| a | x |\n| B | 4 |\n| c | 3 |\n" (org-te
  (if (unwind-protect (setq value-15460 (apply fn-15458 args-15459)) (
  (let (form-description-15462) (if (unwind-protect (setq value-15460 
  (let ((value-15460 'ert-form-evaluation-aborted-15461)) (let (form-d
  (let* ((fn-15458 #'equal) (args-15459 (condition-case err (let ((sig
  (progn (fset 'string-collate-lessp vnew) (let* ((fn-15458 #'equal) (
  (unwind-protect (progn (fset 'string-collate-lessp vnew) (let* ((fn-
  (let* ((vnew #'(lambda (s1 s2 &optional locale ignore-case) (funcall
  (let ((original-string-collate-lessp (symbol-function 'string-collat
  (lambda nil (let* ((fn-15448 #'equal) (args-15449 (condition-case er
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name test-org-table/sort-lines :documentat
  ert-run-or-rerun-test(#s(ert--stats :selector "\\(org\\|ob\\)" :test
  ert-run-tests("\\(org\\|ob\\)" #f(compiled-function (event-type &res
  ert-run-tests-batch("\\(org\\|ob\\)")
  ert-run-tests-batch-and-exit("\\(org\\|ob\\)")
  (let ((org-id-track-globally t) (org-test-selector (if org-test-sele
  org-test-run-batch-tests("\\(org\\|ob\\)")
  eval((org-test-run-batch-tests org-test-select-re) t)
  command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
  command-line()
  normal-top-level()

Test test-org-table/sort-lines condition:
    (ert-test-failed
     ((should
       (equal "| a | x |
| B | 4 |
| c | 3 |
"
	      (org-test-with-temp-text "| <point>a | x |
| c | 3 |
| B | 4 |
" ... ...)))
      :form
      (equal "| a | x |
| B | 4 |
| c | 3 |
"
	     #("| B | 4 |
| a | x |
| c | 3 |
" 0 9
(face org-table)
10 19
(face org-table)
20 29
(face org-table)))
      :value nil :explanation
      (array-elt 2
		 (different-atoms
		  (97 "#x61" "?a")
		  (66 "#x42" "?B")))))


Test test-org/auto-repeat-maybe backtrace:
  signal(ert-test-failed (((should (string-match-p (rx "* TODO Read bo
  ert-fail(((should (string-match-p (rx "* TODO Read book\nSCHEDULED: 
  (if (unwind-protect (setq value-21267 (apply fn-21265 args-21266)) (
  (let (form-description-21269) (if (unwind-protect (setq value-21267 
  (let ((value-21267 'ert-form-evaluation-aborted-21268)) (let (form-d
  (let* ((fn-21265 #'string-match-p) (args-21266 (condition-case err (
  (lambda nil (let* ((fn-21161 #'string-prefix-p) (args-21162 (conditi
  ert--run-test-internal(#s(ert--test-execution-info :test ... :result
  ert-run-test(#s(ert-test :name test-org/auto-repeat-maybe :documenta
  ert-run-or-rerun-test(#s(ert--stats :selector "\\(org\\|ob\\)" :test
  ert-run-tests("\\(org\\|ob\\)" #f(compiled-function (event-type &res
  ert-run-tests-batch("\\(org\\|ob\\)")
  ert-run-tests-batch-and-exit("\\(org\\|ob\\)")
  (let ((org-id-track-globally t) (org-test-selector (if org-test-sele
  org-test-run-batch-tests("\\(org\\|ob\\)")
  eval((org-test-run-batch-tests org-test-select-re) t)
  command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
  command-line()
  normal-top-level()
Test test-org/auto-repeat-maybe condition:
    (ert-test-failed
     ((should
       (string-match-p
	(rx "* TODO Read book
SCHEDULED: <2021-06-16 Wed +1d>
:PROPERTIES:
:LAST_REPEAT:" ... "
:END:
- State \"DONE\"       from \"TODO\"" ... buffer-end)
	(let ... ...)))
      :form
      (string-match-p "\\* TODO Read book
SCHEDULED: <2021-06-16 Wed \\+1d>
:PROPERTIES:
:LAST_REPEAT:.+
:END:
- State \"DONE\"       from \"TODO\".+\\'"
		      #("* TODO Read book
SCHEDULED: <2021-06-16 Mi +1d>
                       ^^
It says Mittwoch instead of Wednesday.


:PROPERTIES:
:LAST_REPEAT: [2021-09-30 Do 07:14]
:END:
- State \"DONE\"       from \"TODO\"       [2021-09-30 Do 07:14]" 0 1
(face org-level-1 org-todo-head "TODO")
1 7
(org-todo-head "TODO")
7 16
(face org-level-1 org-todo-head "TODO")
17 27
(face org-special-keyword)
130 134
(face ...)))
      :value nil))

Re: test-org/auto-repeat-maybe depends on locale

[Ihor Radchenko]

Axel Kielhorn <org-mode@axelkielhorn.de> writes:

> I have just installed Org mode 9.5 and get a few failing tests:
>
> Which LANG = de_DE.UTF-8 I get:
>
> But which LANG = C I get:

I am unable to reproduce both the failures on my side.

Best,
Ihor

Re: test-org/auto-repeat-maybe depends on locale

[Axel Kielhorn]

> Am 26.12.2021 um 16:03 schrieb Ihor Radchenko <yantar92@gmail.com>:
> 
> Axel Kielhorn <org-mode@axelkielhorn.de> writes:
> 
>> I have just installed Org mode 9.5 and get a few failing tests:
>> 
>> Which LANG = de_DE.UTF-8 I get:
>> 
>> But which LANG = C I get:
> 
> I am unable to reproduce both the failures on my side

Neither can I with current org.
Somehow it got fixed, whatever it was.


Greetings
Axel