From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer Date: Sat, 29 Jan 2022 15:49:24 -0800 Message-ID: <878ruyqf0b.fsf__30525.5341388815$1643500225$gmane$org@neverwas.me> References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19207"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: larsi@gnus.org, emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org To: Guy Gastineau Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 30 00:50:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDxU0-0004na-Tc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 00:50:17 +0100 Original-Received: from localhost ([::1]:38506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDxTz-0001Fs-Er for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Jan 2022 18:50:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDxTn-0001FS-CY for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2022 18:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDxTn-0007zK-2J for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2022 18:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nDxTm-0002gO-AB for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2022 18:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jan 2022 23:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53617 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53617-submit@debbugs.gnu.org id=B53617.164350017910271 (code B ref 53617); Sat, 29 Jan 2022 23:50:02 +0000 Original-Received: (at 53617) by debbugs.gnu.org; 29 Jan 2022 23:49:39 +0000 Original-Received: from localhost ([127.0.0.1]:35158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDxTP-0002fa-9V for submit@debbugs.gnu.org; Sat, 29 Jan 2022 18:49:39 -0500 Original-Received: from mail-108-mta220.mxroute.com ([136.175.108.220]:40201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDxTN-0002fN-1V for 53617@debbugs.gnu.org; Sat, 29 Jan 2022 18:49:37 -0500 Original-Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta220.mxroute.com (ZoneMTA) with ESMTPSA id 17ea83e5f8d0005a20.001 for <53617@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 29 Jan 2022 23:49:27 +0000 X-Zone-Loop: 06ccf9c602fe726d1ee04c0b39c17bc4dcc148fc2f33 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HhilBh9CwE4yk+JxosI7Y7N4i1DJIS3t/sQVGgr9his=; b=KbdFBpMF52ZAeE7e/yo5gVIzbP crRr1Q4njnFoSCQo1jP/BYgLtiVgSUZamGA1PtVSZ8jSRf/KlaPwe75j6ZAWRKELUBEF6h9WYo1T6 vXEoX5W618eY60ZRIT3Te8anN44nUj5CjO3sP4yPrMdsgxGYfXdZUdkgcRgM/nMnKK60M4zEfEoxH I1RilUyzm9Reu7ZqnkGOUWvScxNd8Wg8RcC+D4wcX6xPnJavln+cQWL0/5W1Wswco5dyO/017wYJw gsCk12qtKJKaA4PeervLQSk/9ZDjrhA350deSHBy2tUOuYLqwztVX4ovIDpnRwzYKkFwQnTNv6Wnq D0jFmXhw==; In-Reply-To: (Guy Gastineau's message of "Fri, 28 Jan 2022 23:29:31 -0500") X-AuthUser: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225573 Archived-At: --=-=-= Content-Type: text/plain Guy Gastineau writes: > Here it is. I don't think my pgp key is on any keyserver, but I signed > it anyway. I'm not sure if Emacs has a policy regarding the signing of everyday contributions, but if your key isn't signed by anyone and not propagated among the keyservers, then I'd guess you can probably just skip further signing in the near term. > Thank you for the encouragement. My pleasure. This looks ready for Emacs 29. Thanks. . . . I've added the customary tweaks to the log message if someone wants to glance at it (cc. bandali, Lars). Also, question: is there formal recordkeeping going on re exempt lines accumulated per individual? And if not, is the recommended way to get a tally just `git log --author=`? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Remove-redundant-checks-in-erc-switch-to-buffer.patch >From 12352c00544c1916210dd15002ef4ffe0f5efdc8 Mon Sep 17 00:00:00 2001 From: Guy Gastineau Date: Fri, 28 Jan 2022 23:12:42 -0500 Subject: [PATCH] Remove redundant checks in erc--switch-to-buffer * lisp/erc/erc.el (erc--switch-to-buffer): Commit f925fc93bac41d7622d1af927e33b0e738ff55b0 "Add `predicate' arg to `read-buffer' and use it for erc-iswitchb" meant to remove this, but it was left behind. (Bug#53617). Copyright-paperwork-exempt: yes --- lisp/erc/erc.el | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 9ee8d38b02..52fe106f2d 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -1761,12 +1761,7 @@ erc--switch-to-buffer (lambda (bufname) (let ((buf (if (consp bufname) (cdr bufname) (get-buffer bufname)))) - (when buf - (erc--buffer-p buf (lambda () t) proc) - (with-current-buffer buf - (and (derived-mode-p 'erc-mode) - (or (null proc) - (eq proc erc-server-process)))))))))) + (and buf (erc--buffer-p buf (lambda () t) proc))))))) (defun erc-switch-to-buffer (&optional arg) "Prompt for an ERC buffer to switch to. When invoked with prefix argument, use all ERC buffers. Without -- 2.34.1 --=-=-=--