From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: master e087c89b1e: Prevent GTK from setting unreasonable size hints with large menu bars Date: Tue, 22 Feb 2022 09:37:42 +0100 Message-ID: <878ru370vd.fsf@igel.home> References: <164542506993.4058.7868718805924451854@vcs2.savannah.gnu.org> <20220221063110.50C7BC07B76@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3862"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Po Lu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 22 09:40:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMQiM-0000nA-IR for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Feb 2022 09:40:06 +0100 Original-Received: from localhost ([::1]:49626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMQiL-0001sS-4N for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Feb 2022 03:40:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMQgD-00015t-Fa for emacs-devel@gnu.org; Tue, 22 Feb 2022 03:37:59 -0500 Original-Received: from mail-out.m-online.net ([212.18.0.9]:59724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMQgA-0005nQ-WF for emacs-devel@gnu.org; Tue, 22 Feb 2022 03:37:52 -0500 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4K2sxN1YCDz1qyc6; Tue, 22 Feb 2022 09:37:44 +0100 (CET) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4K2sxM6xPqz1qqkD; Tue, 22 Feb 2022 09:37:43 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Z39toZRpn3sB; Tue, 22 Feb 2022 09:37:43 +0100 (CET) X-Auth-Info: WZ1sHxGC+Ga4qovTSFAPtmdzRb28c3WgKVx9h0mwrdPO3ii17ZoqfRXIMRXYxTr2 Original-Received: from igel.home (ppp-46-244-189-177.dynamic.mnet-online.de [46.244.189.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 22 Feb 2022 09:37:43 +0100 (CET) Original-Received: by igel.home (Postfix, from userid 1000) id 9C3342C3659; Tue, 22 Feb 2022 09:37:42 +0100 (CET) X-Yow: So this is what it feels like to be potato salad In-Reply-To: <20220221063110.50C7BC07B76@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Mon, 21 Feb 2022 01:31:10 -0500 (EST)") Received-SPF: pass client-ip=212.18.0.9; envelope-from=whitebox@nefkom.net; helo=mail-out.m-online.net X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286581 Archived-At: On Feb 21 2022, Po Lu via Mailing list for Emacs changes wrote: > diff --git a/src/gtkutil.h b/src/gtkutil.h > index b74244d84d..f850ecc421 100644 > --- a/src/gtkutil.h > +++ b/src/gtkutil.h > @@ -83,6 +83,10 @@ typedef struct xg_menu_item_cb_data_ > > } xg_menu_item_cb_data; > > +#ifdef HAVE_GTK3 > +G_DECLARE_FINAL_TYPE (EmacsMenuBar, emacs_menu_bar, EMACS, MENU_BAR, GtkMenuBar) > +#endif In file included from xdisp.c:467:0: gtkutil.h:87:70: error: expected ‘)’ before ‘GtkMenuBar’ G_DECLARE_FINAL_TYPE (EmacsMenuBar, emacs_menu_bar, EMACS, MENU_BAR, GtkMenuBar) ^ -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."