Re: [PATCH] Fix placement of toggle and radio button in Lucid menu.

[Manuel Giraud <manuel@ledu-giraud.fr>]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

Hi,

Ok so here is a new patch that I think fixes this issue. The first line
of the patch sets the toggle to size to be 2/3 of the ascent (and not
height) of the font: it seems more logical if those buttons resides on
the baseline.

As you can see in the following zoomed screenshots, the base of the
pseudo-3d box is now on the same line of the bottom horizontal bar of a
'i' for instance.

Best regards,

Before patch:

[-- Attachment #2: orig-small-bitmap.png --]
[-- Type: image/png, Size: 2050 bytes --]

[-- Attachment #3: orig-small-vector.png --]
[-- Type: image/png, Size: 9359 bytes --]

[-- Attachment #4: orig-big-bitmap.png --]
[-- Type: image/png, Size: 2448 bytes --]

[-- Attachment #5: orig-big-vector.png --]
[-- Type: image/png, Size: 10295 bytes --]

[-- Attachment #6: Type: text/plain, Size: 13 bytes --]


With patch:

[-- Attachment #7: patch-small-bitmap.png --]
[-- Type: image/png, Size: 2000 bytes --]

[-- Attachment #8: patch-small-vector.png --]
[-- Type: image/png, Size: 9427 bytes --]

[-- Attachment #9: patch-big-bitmap.png --]
[-- Type: image/png, Size: 2519 bytes --]

[-- Attachment #10: patch-big-vector.png --]
[-- Type: image/png, Size: 13519 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #11: 0001-fix-toggle-radio-button-on-lucid.patch --]
[-- Type: text/x-patch, Size: 1351 bytes --]

From 1c56fbc1e294e1ed273d8f0f6a5b71b26047d004 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Fri, 25 Feb 2022 12:04:37 +0100
Subject: [PATCH] fix toggle/radio button on lucid.

---
 lwlib/xlwmenu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lwlib/xlwmenu.c b/lwlib/xlwmenu.c
index ace5141cdb..f49fc3697a 100644
--- a/lwlib/xlwmenu.c
+++ b/lwlib/xlwmenu.c
@@ -393,7 +393,7 @@ arrow_width (XlwMenuWidget mw)
 static int
 toggle_button_width (XlwMenuWidget mw)
 {
-  return (MENU_FONT_HEIGHT (mw) * 2 / 3) | 1;
+  return (MENU_FONT_ASCENT (mw) * 2 / 3) | 1;
 }
 
 
@@ -793,7 +793,7 @@ draw_toggle (XlwMenuWidget mw, Window window, int x, int y, int selected_p)
   width = toggle_button_width (mw);
   height = width;
   x += mw->menu.horizontal_spacing;
-  y += (MENU_FONT_ASCENT (mw) - height) / 2;
+  y += (MENU_FONT_ASCENT (mw) - height);
   draw_shadow_rectangle (mw, window, x, y, width, height, False, selected_p);
 }
 
@@ -810,7 +810,7 @@ draw_radio (XlwMenuWidget mw, Window window, int x, int y, int selected_p)
   width = radio_button_width (mw);
   height = width;
   x += mw->menu.horizontal_spacing;
-  y += (MENU_FONT_ASCENT (mw) - height) / 2;
+  y += (MENU_FONT_ASCENT (mw) - height);
   draw_shadow_rhombus (mw, window, x, y, width, height, False, selected_p);
 }
 
-- 
2.35.1


[-- Attachment #12: Type: text/plain, Size: 18 bytes --]

-- 
Manuel Giraud