From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jai Flack Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: gnus-search-mu Date: Wed, 30 Mar 2022 14:42:32 +1000 Message-ID: <878rssrqyv.fsf@disroot.org> References: <87czib77uz.fsf@disroot.org> <878rszidk9.fsf@ericabrahamsen.net> <87sfr6eunp.fsf@disroot.org> <8735j5tzus.fsf@ericabrahamsen.net> <87ils0yqxd.fsf@disroot.org> <87ilrzuoof.fsf@ericabrahamsen.net> <87ilrz9d2x.fsf@disroot.org> <878rsuvie4.fsf@ericabrahamsen.net> <87bkxqa3l6.fsf@disroot.org> <87pmm433lt.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11276"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 30 13:17:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZWKf-0002jU-QT for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Mar 2022 13:17:45 +0200 Original-Received: from localhost ([::1]:58896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZWKe-0001H7-Oj for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Mar 2022 07:17:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZQAO-0000pg-93 for emacs-devel@gnu.org; Wed, 30 Mar 2022 00:42:44 -0400 Original-Received: from knopi.disroot.org ([178.21.23.139]:49374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZQAL-00064N-E2 for emacs-devel@gnu.org; Wed, 30 Mar 2022 00:42:44 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 591B74022A; Wed, 30 Mar 2022 06:42:38 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u0TiXV8CI9LJ; Wed, 30 Mar 2022 06:42:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1648615357; bh=+R09Md7+dfiMP+kTrFMSMNHRKjiC8lsuL3uDsjPt8B0=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=QYqq0+LTFZFT9G3NoKO1BX4CRfBfCzsPl8lCCZJHywM6dybBFvMp4dfEGG7N8iTPM Vogz9rpHInUU6rCbxyZ0BH/AMe/ssuHErpyLLuB/cU3+9KpBT117D1NKfFhVabSMAe r5hKlb3pgg3urjwk0XCsdH5QKuS0QmREV3rjL5IfTO8n3L4ShB5eifRJSth0LsKHyB sUGWND0FofyrgOeMiFSpz3ELmR9SkkVJ+/s3AarTGf/UnEqEQzbkyNJysrxsOYpP4g 89ljCM0jq088+3padAopta7h6lnYmnp7e+nJ5hl3aEkLmBB6zczuszS0mWiZWSWNie 7CCxuke20bfyg== In-Reply-To: <87pmm433lt.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 29 Mar 2022 13:28:46 -0700") Received-SPF: pass client-ip=178.21.23.139; envelope-from=jflack@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 30 Mar 2022 07:16:59 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287605 Archived-At: Eric Abrahamsen writes: > Jai Flack writes: > >> Eric Abrahamsen writes: >> >>>> Were there any docstrings in particular you noticed that didn't make up >>>> a complete sentence? I've updated them to be (roughly) the same as the >>>> notmuch and namazu backends but the first lines already matched. >>> >>> Sorry, that was poorly phrased. I meant the first sentence of the docstring >>> should all fit on a single line. Like this: >>> >>> (defcustom gnus-search-mu-raw-queries-p nil >>> "If t, all mu engines will only accept raw search query >>> strings. >>> >>> This can also be set per-server." >>> :type 'boolean >>> :group 'gnus-search) >>> >>> The first sentence should be munged until it doesn't wrap, then the >>> second blank line doesn't need to be there. A la the "Tips for >>> Documentation Strings" section of the Elisp manual. >> >> Ah right. >> >>> (If gnus-search.el itself doesn't fully adhere to these conventions, >>> well... I'll get there eventually.) >> >> I also noticed some of the defcustom :types don't match (like >> `gnus-search-*-remove-prefix). Probably wouldn't save you any time >> writing a patch for these. >> >>>>>>> Out of curiosity, what is `ansi-color-filter-apply' doing there? >>>>>> >>>>>> I think I had trouble with mu giving ANSI escape codes to Emacs, it >>>>>> might no longer be a problem or maybe there is a better solution. >>>>> >>>>> Okay, sounds good! ansi-color is built in so there's no harm in that. >>>> >>>> I've changed this to use the --nocolor option for mu. >>> >>> Even better. >>> >>>>> I'm assuming you have done copyright assignment. Do you have push >>>>> permissions for ELPA and/or Emacs proper? >>>> >>>> Done copyright assignment. Don't have any push permissions. >>> >>> Are you expecting to ask for permission? (I'm not able to grant it.) If >>> not, I can push these things for you. >> >> I wasn't planning on asking for permission. Not sure about the process >> but I assume a bit more trust is required than a potential patch and a >> couple potential ELPA packages. > > Worked for me! Ha. > >>>> For the ELPA package is there a good way to signal to users that the >>>> built-in version should be used on a recent-enough Emacs version? >>> >>> I think your current Package-Requires header is the best we can do. I >>> haven't actually tested if it will refuse to install on Emacs < 28.1, >>> but I think due diligence is done. >> >> Not sure if you misunderstood me, I meant a warning for Emacs > 28 when >> the mu backend will (hopefully) be a part of Emacs. >> >> Though it will possibly not like the current pretest 28.0.92 < 28.1. > > Oh... I actually don't know how that's supposed to work -- if there's > some automatic machinery in place to prefer the built-in version when > it's newer than the package. We'd have to ask the experts. > > Packaging experts? Is there anything special that has to be done? I think the package is ready for GNU ELPA, I made a couple little cleanup changes and requested a NonGNU Savannah repo for it. I'll start writing the extra documentation for the patch then submit it to bug-gnu-emacs. -- Thanks, Jai