From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#54636: dired fails to update subdirs when files are created/deleted/renamed Date: Wed, 30 Mar 2022 18:02:15 +0200 Message-ID: <878rsr1kss.fsf@gnu.org> References: <877d8b3d4w.fsf@igel.home> <87y20r1vys.fsf@igel.home> <87o81n1ue5.fsf@gnu.org> <835ynv8ti4.fsf@gnu.org> <87k0cb1rpa.fsf@gnu.org> <831qyj8rxl.fsf@gnu.org> <87czi31p1l.fsf@gnu.org> <83zgl7780z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4380"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.12; emacs 29.0.50 Cc: 54636@debbugs.gnu.org, schwab@linux-m68k.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 30 18:13:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZawi-00011m-Am for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 18:13:20 +0200 Original-Received: from localhost ([::1]:38220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZawh-0002sW-Am for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 12:13:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZawR-0002mt-2d for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 12:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42817) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZawQ-0001BK-JR for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 12:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZawQ-0005sR-7t for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 12:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2022 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54636 X-GNU-PR-Package: emacs Original-Received: via spool by 54636-submit@debbugs.gnu.org id=B54636.164865676922571 (code B ref 54636); Wed, 30 Mar 2022 16:13:02 +0000 Original-Received: (at 54636) by debbugs.gnu.org; 30 Mar 2022 16:12:49 +0000 Original-Received: from localhost ([127.0.0.1]:36714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZawC-0005rz-Py for submit@debbugs.gnu.org; Wed, 30 Mar 2022 12:12:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZawB-0005rm-4Y for 54636@debbugs.gnu.org; Wed, 30 Mar 2022 12:12:47 -0400 Original-Received: from [2001:470:142:3::e] (port=38534 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZaw4-00019l-RL; Wed, 30 Mar 2022 12:12:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=BGy8zmdrT2hi6IfMRFF6SIyIeO0svpdLc4VEP7ENzSM=; b=V3GF0ZwpS8PDPt IY4aGxvfVzf2wD13HG8Bp0XfTtxgUjicr5lz95443XhxyrCCFxwGo6dl1t4xM9FQ+3jiqnbg88oao 4NcfqywcElWvapP8160lUurEfbfW73ZjyMUkiEYyUo4mM38IkSsvnzDN0xJIqWhMadUUvUbwV/zD9 eeMAoCjX06UMUooNL+XOWFLizto1bAtFeEdIDGpW5EVClEbn0NHPLe4qBb891ircSjV0XrBxliP8t uCA8+n0JQ2q0bMvG4oooPEvNSA9NwCzf+2EB3bATvpmTKb/gHOSWFfsoNuCrqg3PBTB0J+C+MM8YE 3+hhJAKfzrf4/MwgiM6Q==; Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:56907) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZaw3-000576-82; Wed, 30 Mar 2022 12:12:40 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 96A4727C005B; Wed, 30 Mar 2022 12:12:38 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 30 Mar 2022 12:12:38 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeivddgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepve evieekteekveeigfefffeivdetgeduvdffueeuudevgedttdehvdfhueevfffhnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Mar 2022 12:12:37 -0400 (EDT) In-reply-to: <83zgl7780z.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229119 Archived-At: Eli Zaretskii writes: >> From: Tassilo Horn >> Cc: schwab@linux-m68k.org, 54636@debbugs.gnu.org >> Date: Wed, 30 Mar 2022 16:30:22 +0200 >> >> Here's a patch. I've created a separate cond-arm for the SUBDIRS case, >> so any callers which are not dired-clean-up-after-deletion (the only one >> setting SUBDIRS) are not affected. > > Thanks. > > So when will SUBDIRS be non-nil? dired-clean-up-after-deletion is > called not only when a directory is deleted, I think. Yes, it's also called when deleting a file but in that case dired-buffers-for-dir will return nil, so no buffer will be deleted. Probably, I shouldn't even bother to call it if a file has been deleted. I think my patch is valid but now I think I should just create a separate function dired-buffers-for-cleanup and use that from dired-clean-up-after-deletion (or just collect the buffers in that function) and remove the SUBDIRS argument from dired-buffers-for-dir as it changes its logic too drastically. I'll prepare a patch in that direction later. Bye, Tassilo