From: Michael Albinus <michael.albinus@gmx.de>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 54606@debbugs.gnu.org
Subject: bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers
Date: Fri, 01 Apr 2022 09:06:14 +0200 [thread overview]
Message-ID: <878rspffkp.fsf@gmx.de> (raw)
In-Reply-To: <4e51611a497c4fd3e7fab2c357d5cc3a@webmail.orcon.net.nz> (Phil Sainty's message of "Fri, 01 Apr 2022 07:09:38 +1300")
Phil Sainty <psainty@orcon.net.nz> writes:
Hi Phil,
>>> If you want to go *this* direction, there would be a simple change:
>>> (equal (file-remote-p dir)
>>> (file-remote-p default-directory))
>>> file-remote-p doesn't do anything on wire.
>> I think that sounds like a good change here anyway.
>
> Agreed -- if I'd checked to see what file-remote-p actually
> returned, I would done this myself from the outset.
>
> I've tested this approach in isolation, and it works well
> in my test instance.
So I've pushed this to master.
> I've not yet tested to see whether the `non-essential'
> change is similarly efficient in a newer version with a
> similar session.
It will help for buffers with a broken remote connection. I've pushed
this change as well.
> Lars' suggestion of having these commands NOT checking
> every dired buffer every time also seems very sensible.
From my pov, this bug could be closed. However, I'll keep it open in
case something else shall be changed, too. But that I won't investigate
myself.
> -Phil
Best regards, Michael.
next prev parent reply other threads:[~2022-04-01 7:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 10:13 bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers Phil Sainty
2022-03-29 13:03 ` Lars Ingebrigtsen
2022-03-29 13:09 ` Michael Albinus
2022-03-30 11:43 ` Phil Sainty
2022-03-30 11:51 ` Michael Albinus
2022-03-30 12:03 ` Lars Ingebrigtsen
2022-03-31 9:47 ` Michael Albinus
2022-03-31 11:41 ` Lars Ingebrigtsen
2022-03-31 18:09 ` Phil Sainty
2022-04-01 7:06 ` Michael Albinus [this message]
2022-04-02 13:02 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rspffkp.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=54606@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.