From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too Date: Mon, 11 Apr 2022 16:55:38 +0200 Message-ID: <878rsbacut.fsf@gnus.org> References: <164967696186.12152.11548736665906939483@vcs2.savannah.gnu.org> <20220411113602.7A114C0581E@vcs2.savannah.gnu.org> <87bkx73jfz.fsf@yahoo.com> <83r16369xx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1252"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Po Lu , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 11 17:09:27 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndvfT-000Ab3-AV for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 17:09:27 +0200 Original-Received: from localhost ([::1]:48360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndvfR-0006zj-EV for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 11:09:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndvSE-00044G-Mc for emacs-devel@gnu.org; Mon, 11 Apr 2022 10:55:49 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:55474) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndvSD-0000HV-8i; Mon, 11 Apr 2022 10:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IkDK+RJ7rpv62g/+wFx6xPL4cQm2amjHvHtdyDQ3BS0=; b=FluOWXhlpa/CrJuqYikEf/fEy3 ARt+e4l6veFbVDsuWlYNFFa1UNRajT7RUCbZ8cYLEcU+q25XtYGY9K1SQb4FJy3h6JQoquUEUY6q7 ygW5Q1WIkAeKPHbTwLC5PGtiRAlb601x3Z+yGPbxQmS3P7lt/Er5uYZ/HGjIRAq4czJo=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndvS8-0004a4-Mn; Mon, 11 Apr 2022 16:55:43 +0200 In-Reply-To: <83r16369xx.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Apr 2022 16:12:10 +0300") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288215 Archived-At: Eli Zaretskii writes: >> I think this should be marked, since I don't see what protects the spec >> from garbage collection otherwise. > > 'spec' here is img->spec, right? But the spec in the cache might be from a different img (we're looking through the cache for the right one), so the spec there may have been gc'd. So Po Lu's fix was the right one here, I think (and has been pushed now). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no