From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Subject: Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too
Date: Mon, 11 Apr 2022 16:55:38 +0200 [thread overview]
Message-ID: <878rsbacut.fsf@gnus.org> (raw)
In-Reply-To: <83r16369xx.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Apr 2022 16:12:10 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> I think this should be marked, since I don't see what protects the spec
>> from garbage collection otherwise.
>
> 'spec' here is img->spec, right?
But the spec in the cache might be from a different img (we're looking
through the cache for the right one), so the spec there may have been
gc'd. So Po Lu's fix was the right one here, I think (and has been
pushed now).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2022-04-11 14:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164967696186.12152.11548736665906939483@vcs2.savannah.gnu.org>
[not found] ` <20220411113602.7A114C0581E@vcs2.savannah.gnu.org>
2022-04-11 12:15 ` master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too Po Lu
2022-04-11 12:44 ` Lars Ingebrigtsen
2022-04-11 12:56 ` Po Lu
2022-04-11 13:04 ` Lars Ingebrigtsen
2022-04-11 13:12 ` Po Lu
2022-04-11 13:15 ` Lars Ingebrigtsen
2022-04-11 13:29 ` Po Lu
2022-04-11 13:58 ` Stefan Monnier
2022-04-11 14:55 ` Lars Ingebrigtsen
2022-04-11 13:12 ` Eli Zaretskii
2022-04-11 13:14 ` Lars Ingebrigtsen
2022-04-11 13:22 ` Eli Zaretskii
2022-04-11 13:25 ` Po Lu
2022-04-11 13:29 ` Eli Zaretskii
2022-04-11 13:32 ` Po Lu
2022-04-11 14:55 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rsbacut.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.