all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: master 1b71c995da: Avoid binding mouse-1 in xref when mouse-1 doesn't follow links
Date: Sat, 30 Apr 2022 13:39:35 +0200	[thread overview]
Message-ID: <878rrm4x6w.fsf@gnus.org> (raw)
In-Reply-To: <5371c7d3-2677-f89c-ed4c-05a4f664c9be@yandex.ru> (Dmitry Gutov's message of "Fri, 29 Apr 2022 19:16:11 +0300")

Dmitry Gutov <dgutov@yandex.ru> writes:

>> Dmitry seems to like the two different actions (which only differ in
>> whether the other buffer is selected or not).  I'd be fine with removing
>> the mouse-1 binding.
>
> TBH, I don't really mind either way. I don't use the mouse in these
> buffers (and rarely do that at all in Emacs).
>
> I proposed a slightly different change in the past
> (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35353#77), but if other
> similar modes (like Grep and Occur) behave differently and
> consistently between themselves, it probably makes sense to follow
> their example.

So I've now removed the mouse-1 binding to make this map work like most
other buttons.  (I have no opinion as to whether to keep xref-goto-xref
or xref-select-and-show-xref as the binding, so I kept the mouse-2
binding.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2022-04-30 11:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165123369667.6415.4605821518748112960@vcs2.savannah.gnu.org>
     [not found] ` <20220429120137.0F053C06322@vcs2.savannah.gnu.org>
2022-04-29 13:00   ` master 1b71c995da: Avoid binding mouse-1 in xref when mouse-1 doesn't follow links Stefan Monnier
2022-04-29 13:16     ` Lars Ingebrigtsen
2022-04-29 15:34       ` [External] : " Drew Adams
2022-04-29 16:16       ` Dmitry Gutov
2022-04-30 11:39         ` Lars Ingebrigtsen [this message]
2022-05-01 12:14           ` Dmitry Gutov
2022-05-02  8:02             ` Lars Ingebrigtsen
2022-04-29 17:17       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rrm4x6w.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.