From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jai Flack Newsgroups: gmane.emacs.devel Subject: Re: Package Requiring a Commit? Date: Thu, 05 May 2022 14:40:16 +0000 Message-ID: <878rrgyre7.fsf@posteo.net> References: <87fslp7c97.fsf@posteo.net> <87ee18ifpr.fsf@posteo.net> <87fsloe5a4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37296"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 05 18:42:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmeYY-0009XE-Rg for ged-emacs-devel@m.gmane-mx.org; Thu, 05 May 2022 18:42:22 +0200 Original-Received: from localhost ([::1]:41550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeYX-0005Nd-JX for ged-emacs-devel@m.gmane-mx.org; Thu, 05 May 2022 12:42:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmcef-0005cd-KH for emacs-devel@gnu.org; Thu, 05 May 2022 10:40:33 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:34035) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmceZ-0000Nu-5B for emacs-devel@gnu.org; Thu, 05 May 2022 10:40:33 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 38C0F240028 for ; Thu, 5 May 2022 16:40:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1651761622; bh=HuTozv8LC6bEqDpCXvm4NR7QXSx/DHA9mmuKleAwvRA=; h=From:To:Cc:Subject:Date:Autocrypt:OpenPGP:From; b=DBjcXtCFrvIBr2CLkGqHR5qh77pnnew1oseZu2Piq/EyYFbFuTi4OOcnKkbQ3fMHZ PaPd3OORGc0j6ng1Zi4LRoPlS3GuA+inUnz1iFMWJ0TvaU6qCP4vS3VvBYmJFTwGLW FyzXlffvP8z3YBJYD41Sh0kKauDTfe86ZFNFWtCYUgH5LarhBd36Qw2k/lDIEfvzyx K0FFgENXi1hDgjJi5V/V34Y41FD5n54LmozsUpHICD7oUaOU4RThB2bj2GmvtxblQo hZ4XB4dlrCytLZj1lP0d6DacKzCI2g0TGP2wZK3uD2tyWgXjKJ8dHvbTROt7Y0ztS0 IT5FABOn1HwzQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4KvGZX1D4wz9rxV; Thu, 5 May 2022 16:40:19 +0200 (CEST) In-Reply-To: <87fsloe5a4.fsf@gnu.org> (Tassilo Horn's message of "Thu, 05 May 2022 10:37:47 +0200") Autocrypt: addr=jflack@posteo.net; keydata=xsFNBGJIFUgBEACetRpyAEayP9fB/LvYi9sUIQwXH5EKN6uHrjc6RqlKju6jx2tu2F0HYjsiJ1xUfUUhuwdrEFpAGxM9XHFbNhrtIAh0ckOiALMexQP+n6uJgSq/u+3gqdKVmI2cgb2ruEcDR1t9QpuETTKPNj7k8sQoUjj907kACVL/XKfJC9csbAECYtfbbWtl6KJi5qQsF1N3kyHtF6k6Ly/tkq+CPY9RkEkraWNhJtrE509g/BbIIn3BzvrtboDwOX2JucrBojfaehvRzWnwrbTxTb+tsIjBSrFNJgOwa0PYtF7F15nCZ9254DJA7oyBqY/4B8iGGYbVBeQdU0/noVtui9JlLzU9tKOfKjm+js1Eu9vlAK2poZaR7uMy3cOQ+SPh7BdMSE/4HThDil6nq/LaPmX/bS1rFR01ztLxM/YEeDTWXT9/mqWM7l06Am0xCK8m99MjKnJiWtsUu4eQdw53GJL563RRw9rnOVEib8nbZcBWu5PfF8hnzyKgPe8fTjJBln1kZbbVv/ytxFXMlwwJPSD5xVPmaTo7gn1gBgoQ2w6CH4OVAdLLa9E0cVsq4w7NcZk2wfryYRylz4h/hdxkuatjq/f6SR860IfgPcS9IFszATRw/PGswx4FeffuV6UoPvMdWQy4KJQ239ou+5Hecce6Y4gYosC1yK34YMgjXEH04um5gwARAQABzRFqZmxhY2tAcG9zdGVvLm5ldMLBlAQTAQoAPhYhBDIm8Qj4YWAFs5cgmxqfJR2Uid2eBQJiSBVIAhsDBQkFo5q ABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEBqfJR2Uid2ecj8QAJEcWZf+HM OpenPGP: url=https://posteo.de/keys/jflack@posteo.net.asc Received-SPF: pass client-ip=185.67.36.65; envelope-from=jflack@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 05 May 2022 12:37:49 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289249 Archived-At: Tassilo Horn writes: > Jai Flack writes: > >>> This should work, just use next version: >>> >>> ;; Package-Requires: ((emacs "29")) >>> >>> Then people running Emacs which was built recently from master will be >>> able to install your package, because they're "already on 29". >> >> Thanks that solves one of the issues. Is there no good solution to the >> other? I can imagine some users building from master for a specific >> feature (say, PGTK) and then not updating. > > For something like "at least as new as commit XXX" Emacs would need to > carry its complete commit graph with it in order to check that > requirement. > > So it's best to just require emacs 29. I personally have no big empathy > for people running outdated development snapshots [1] but if you do, it > shouldn't be too hard to fail gracefully by testing for > functions/variables you need using (f)boundp. > > Bye, > Tassilo > > [1] Simply because during development it may happen that new things are > tweaked/renamed many times until finished. I'm not necessarily after requiring specific commits but yes I suppose something like that isn't a reasonable expectation. -- Thanks, Jai