bug#56636: 28.1.90; bibtex-beginning-of-entry does not always move point the the actual beginning

bug#56636: 28.1.90; bibtex-beginning-of-entry does not always move point the the actual beginning

[Ihor Radchenko]

Hi,

Consider the following BibTeX entry:

@misc{placeholder,
  author =	 {Mamoru Miura <mamo0110@gmail.com>},
  created =	 {[2022-07-19 Tue 09:44]},
  howpublished = {ML:Org mode},
  link =
                  {notmuch:id:9F4AA657-D34B-4B85-A80D-1DD4B3017DB2@gmail.com},
  note =	 {Online; accessed 19 July 2022},
  title =	 {Re: Bug: Appointments duration and effort sums in
                  agenda column view [9.3.7 (release_9.3.7-700-ga1e5be
                  @ ~/.emacs.d/straight/build/org/)]},
  typealt =	 {email},
  year =	 2022,
}

Put the point at the "year" field and run
M-: (bibtex-beginning-of-entry)

Observed: Point moves to the @ ~/.emacs.d line.
Expected: Point moves to @misc

The problem is not only with the direct call to
bibtex-beginning-of-entry, but also shows up in functions that make use
of this function. For example, (bibtex-generate-autokey) or
(bibtex-autokey-get-title) will treat "title" field as empty in the
above scenario.

Best,
Ihor

In GNU Emacs 28.1.90 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.16.0)
 of 2022-07-17 built on localhost
Repository revision: f5218385c064aa959650bfe49ca32795270851eb
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Gentoo Linux

bug#56636: 28.1.90; bibtex-beginning-of-entry does not always move point the the actual beginning

[Lars Ingebrigtsen]

Ihor Radchenko <yantar92@gmail.com> writes:

> @misc{placeholder,
>   author =	 {Mamoru Miura <mamo0110@gmail.com>},
>   created =	 {[2022-07-19 Tue 09:44]},
>   howpublished = {ML:Org mode},
>   link =
>                   {notmuch:id:9F4AA657-D34B-4B85-A80D-1DD4B3017DB2@gmail.com},
>   note =	 {Online; accessed 19 July 2022},
>   title =	 {Re: Bug: Appointments duration and effort sums in
>                   agenda column view [9.3.7 (release_9.3.7-700-ga1e5be
>                   @ ~/.emacs.d/straight/build/org/)]},
>   typealt =	 {email},
>   year =	 2022,
> }
>
> Put the point at the "year" field and run
> M-: (bibtex-beginning-of-entry)
>
> Observed: Point moves to the @ ~/.emacs.d line.
> Expected: Point moves to @misc

I guess the problem is with the @ in the title entry?

I've added Roland to the CCs; perhaps he has some comments.

bug#56636: 28.1.90; bibtex-beginning-of-entry does not always move point the the actual beginning

[Ihor Radchenko]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> Observed: Point moves to the @ ~/.emacs.d line.
>> Expected: Point moves to @misc
>
> I guess the problem is with the @ in the title entry?

Yes, bibtex-beginning-of-entry is doing
(re-search-backward "^[ \t]*@" nil 'move) which does not match the right
thing in this particular case.

Best,
Ihor

bug#56636: 28.1.90; bibtex-beginning-of-entry does not always move point the the actual beginning

[Roland Winkler]

On Sat, Jul 23 2022, Ihor Radchenko wrote:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>>> Observed: Point moves to the @ ~/.emacs.d line.
>>> Expected: Point moves to @misc
>>
>> I guess the problem is with the @ in the title entry?
>
> Yes, bibtex-beginning-of-entry is doing
> (re-search-backward "^[ \t]*@" nil 'move) which does not match the right
> thing in this particular case.

This old part of the code should use bibtex-entry-maybe-empty-head.

Looking at the code, it frequently performs a strange dance
where a call of bibtex-beginnig-of-entry is followed by
(looking-at bibtex-entry-maybe-empty-head).
That doesn't make sense, it works around the above bug instead of
doing it right in the first place.  I'll look for a better solution
for this.

bug#56636: 28.1.90; bibtex-beginning-of-entry does not always move point the the actual beginning

[Lars Ingebrigtsen]

Roland Winkler <winkler@gnu.org> writes:

> That doesn't make sense, it works around the above bug instead of
> doing it right in the first place.  I'll look for a better solution
> for this.

Thanks.

bug#56636: 28.1.90; bibtex-beginning-of-entry does not always move point the the actual beginning

[Ihor Radchenko]

Roland Winkler <winkler@gnu.org> writes:

> Looking at the code, it frequently performs a strange dance
> where a call of bibtex-beginnig-of-entry is followed by
> (looking-at bibtex-entry-maybe-empty-head).
> That doesn't make sense, it works around the above bug instead of
> doing it right in the first place.  I'll look for a better solution
> for this.

May I know if there is any progress on this?

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92

bug#56636: 28.1.90; bibtex-beginning-of-entry does not always move point the the actual beginning

[Ihor Radchenko]

Ihor Radchenko <yantar92@gmail.com> writes:

> May I know if there is any progress on this?

Pinging once more. Maybe this can be fixed before Emacs 29?

Though it is probably not very high priority.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

bug#56636: 28.1.90; bibtex-beginning-of-entry does not always move point the the actual beginning

[Roland Winkler]

>> May I know if there is any progress on this?
>
> Pinging once more. Maybe this can be fixed before Emacs 29?
>
> Though it is probably not very high priority.

I do have a ptach that I'll install shortly (my internet access is
limited right now).

bug#56636: 28.1.90; bibtex-beginning-of-entry does not always move point the the actual beginning

[Ihor Radchenko]

Roland Winkler <winkler@gnu.org> writes:

>> Though it is probably not very high priority.
>
> I do have a ptach that I'll install shortly (my internet access is
> limited right now).

Thanks a lot!

bug#56636: 28.1.90; bibtex-beginning-of-entry does not always move point the the actual beginning

[Roland Winkler]

On Sun, Nov 27 2022, Ihor Radchenko wrote:
> Roland Winkler <winkler@gnu.org> writes:
>
>>> Though it is probably not very high priority.
>>
>> I do have a ptach that I'll install shortly (my internet access is
>> limited right now).
>
> Thanks a lot!

commit 644c71d6788d268cb065bd9317efb8a16a8236e6