From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#56757: 29.0.50; Python f-string font-lock logic is incomplete Date: Mon, 25 Jul 2022 02:06:36 -0700 Message-ID: <878roh5zoj.fsf@secretsauce.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26561"; mail-complaints-to="usenet@ciao.gmane.io" To: 56757@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 25 11:08:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFu4V-0006f5-EG for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Jul 2022 11:08:16 +0200 Original-Received: from localhost ([::1]:33980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFu4U-0008TD-4l for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Jul 2022 05:08:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFu3N-0008PS-Tz for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2022 05:07:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59504) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFu3N-00082g-Kr for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2022 05:07:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFu3K-0003yQ-GC for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2022 05:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jul 2022 09:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56757 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.165874000815253 (code B ref -1); Mon, 25 Jul 2022 09:07:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Jul 2022 09:06:48 +0000 Original-Received: from localhost ([127.0.0.1]:49253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFu36-0003xw-DB for submit@debbugs.gnu.org; Mon, 25 Jul 2022 05:06:48 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFu34-0003xp-NG for submit@debbugs.gnu.org; Mon, 25 Jul 2022 05:06:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFu34-0008GO-IK for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2022 05:06:46 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:36553) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFu32-00081W-9c for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2022 05:06:45 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4F6085C0106 for ; Mon, 25 Jul 2022 05:06:40 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 25 Jul 2022 05:06:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1658740000; x=1658826400; bh=qEfHsOQZOClOAwE0ToVTV7jc6JM1c+9Ej09 PWqk5dis=; b=P7MNz2PHVl5/cSLJM2R/cgC32Cyox24dj3gIjfb29amKAS6nB7v qb+gNST+9Cik/SrYi4OBpo2BjHSkgadsWai1j5udzAh2MvJB5w5aBfCIOXGCOHnq uaj9McyDCbKXOh27RVW8+ICNjQPvly3tFNcKmRiVg0Dtzw3kqz+eZa8iE+YNEq8D J6Iy/6Uq47B1JE3u2LCH4xBBf8L/d7/5097gv9WgXyzWfVuv/saFni6qd5mnbtul kRC3pJpSJMyYw/ifIzWZgqD459PtwuQQjP3iBREbmLPNu+m5VHtlFhunx8BzFepG CddYjQw97BE0fMNsLIftuYjWM5Lzn4osCQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658740000; x= 1658826400; bh=qEfHsOQZOClOAwE0ToVTV7jc6JM1c+9Ej09PWqk5dis=; b=2 bdJ9z7NHd/4dWGiX9Ed4YTDweKQ2IMZumATtL4IPuyo9NPPRugbnHetMdHcunh6l N1qevKOePjDmhGcBEZrhZgsq3lmF1CAFcKnK4WC6VR1naQp2KnkSAPNpuyWGO2Hg IwurcMN92xtMuldbyPGWkzmhSbkrAYQV1evgS4Cq/BfwF99hByuy669FmX+x6tXu TFlW4TBAsJvN9f2FDgc0NpaJLYgE+dMyIGNkiSuo/aX5cyYhciZcovpXGM1kjyRI ae3DK96xk7W8NkrdrK+Gaj4ySjkskIkdgUxmDvCXXuEeEjUXZWlV4KQondjFzVVd C+m19crmFh8HwA1tzmBQw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtkedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehttdertddttd dtnecuhfhrohhmpeffihhmrgcumfhoghgrnhcuoeguihhmrgesshgvtghrvghtshgruhgt vgdrnhgvtheqnecuggftrfgrthhtvghrnhepffdvffduhfekfffhieefhfffvddtgfefje evuedvfedujeejudevfedtgeeguedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepughimhgrsehsvggtrhgvthhsrghutggvrdhnvght X-ME-Proxy: Feedback-ID: i3e8042a0:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 25 Jul 2022 05:06:39 -0400 (EDT) Received-SPF: pass client-ip=66.111.4.27; envelope-from=dima@secretsauce.net; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237878 Archived-At: Hi. Currently python-mode has syntax highlighting to display the part of the string being interpolated (the {...} stuff) differently from the rest of the string. The emacs python-mode has logic to detect f-strings to turn this highlighting on/off properly. It looks like this logic is incomplete, however: it doesn't handle ''' and """ and r strings. (It doesn't handle b strings either, but fb'asdf' is not legal Python, so that's fine). This is legal Python, and {x} is expanded to '5' in each case when the program is executed. x = 5 ss = (f'''aaa {x} bbb''', fr'''aaa {x} bbb''', rf'''aaa {x} bbb''', f"""aaa {x} bbb""", fr"""aaa {x} bbb""", rf"""aaa {x} bbb""", f'aaa {x} bbb', # this is highlighted properly fr'aaa {x} bbb', rf'aaa {x} bbb', f"aaa {x} bbb", # this is highlighted properly fr"aaa {x} bbb", rf"aaa {x} bbb",) for s in ss: print(s) However the {x} is highlighted as code only on the lines marked above. The other lines should have this highlighting also. Thanks!