From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Payas Relekar Newsgroups: gmane.emacs.devel Subject: Re: Progress on merging Eglot? Date: Mon, 19 Sep 2022 14:55:05 +0530 Message-ID: <878rmfiuiv.fsf@gmail.com> References: <8735d1ajxb.fsf@gmail.com> <874jxhaizf.fsf@gmail.com> <87zgf993py.fsf@gmail.com> <87fsgod4ee.fsf@gmail.com> <87czbriv18.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18189"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.9; emacs 29.0.50 Cc: Stefan Monnier , emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 19 13:33:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaF1x-0004aX-2J for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 13:33:41 +0200 Original-Received: from localhost ([::1]:35396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaF1v-00013r-S5 for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 07:33:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaD3o-0000YC-PM for emacs-devel@gnu.org; Mon, 19 Sep 2022 05:27:28 -0400 Original-Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:37847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaD3m-0003ht-Vx for emacs-devel@gnu.org; Mon, 19 Sep 2022 05:27:28 -0400 Original-Received: by mail-pj1-x102c.google.com with SMTP id o99-20020a17090a0a6c00b002039c4fce53so957287pjo.2 for ; Mon, 19 Sep 2022 02:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date; bh=0pf2E9fHCCY4aGnajrHD6sIxpXR3ojlJZD7DOrZBO9Y=; b=NLPJ6qCURiyAUV2kZ8DS2OGiza7rE1klWZqxldi22DabB7J7R4Zb8iklcae8irnyh+ /JdJq5S5zOfn8xxOyxQmrDwcMDkSzzRfBnfT9hmUz8WQiNYF9byec0JTyLIyS56eFHoJ Gnp+Sb4oZhQQcLeN6rmcShmLKTT8GfDDTyuL3wDBNTpNtvWmSKei+QHNzejSuAa9G6c/ sH6MKxY7s49J3+PBpIpztlBkRa2Mf2tsB6zz6nZCg4Ht7s5W4qKwhd5mN4UJ2qYcQ01t APCd3vj4NaJo1nLjwgKxfTNwjHmhhVdSFGmjFIvkXEpYgmMw5YrA8Q4YQ4jcY03ESrN0 8cFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date; bh=0pf2E9fHCCY4aGnajrHD6sIxpXR3ojlJZD7DOrZBO9Y=; b=58pd4jvx0iAGQh6uhJhz7vPVN5W01k68BAPITjF6cQDc1NGVBhkm/+JdkHnaz7njB1 K9KjJClZpF1i4RFSH9e961hIGq4ZT0RSXIEi891FYFbkssqLYRAIv/7dCJAw1utg4/Se 48coAmbGCxgzI8b8LL9ozzM3bsd50+rRdi660mkqv1N9J/aWH2o0QdxgjdhOo9o8O/ze X8Ql+Ly3NiVIy5CEVdWCXbZ8kVQie62OU7E2Gt396EpYcXdu0jX2qfFivPt4lIJRzveQ G/wQTzDJL6MEUc/qhDGyC84BAVRzmGxirOU93fI2CJXlTl/TzrW5g5bP9HR36jZVWCX7 W3Dg== X-Gm-Message-State: ACrzQf2xCoeAeNmo8z0+mzkjp84d49MQ3grM2Bc/kWH05L/3i0hd1reK c6UwoqdW5xbBO3rbFxSFlyU= X-Google-Smtp-Source: AMsMyM5z+SgY7iRd6YopSCCce0+/cKzev5twLeQ9W0EvqF8coQqJA/uFtjEOPx9HG61f/02oyjuu0w== X-Received: by 2002:a17:902:f807:b0:178:516c:128f with SMTP id ix7-20020a170902f80700b00178516c128fmr12056724plb.77.1663579644957; Mon, 19 Sep 2022 02:27:24 -0700 (PDT) Original-Received: from localhost ([150.107.26.19]) by smtp.gmail.com with ESMTPSA id cp16-20020a170902e79000b0016d6c939332sm19922908plb.279.2022.09.19.02.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 02:27:24 -0700 (PDT) In-reply-to: <87czbriv18.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=relekarpayas@gmail.com; helo=mail-pj1-x102c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 19 Sep 2022 07:30:43 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295664 Archived-At: Payas Relekar writes: > Jo=C3=A3o T=C3=A1vora writes: > >> I haven't had the to look at this in depth, but this looks mighty fine, >> including this last idea of putting two "fixes" found in the subject line >> in two lines of the body. >> > Alright! I think we have everything we need. I took the append URLs to > bottom of commit message approach. Here's what we have: > > - History visible for file lisp/progmodes/eglot.el > - Commit message length undisturbed > - every #num is appended with appropriate URL at the bottom of commit > message > > These are the latest and (hopefully) final URLs: > > Code: > https://gist.github.com/bhankas/422c34db2e987d4dc3f243e26ba156a3 > > (Please ensure eglot2emacs.py is in same directory as eglot/ and emacs/ > repos) > > Emacs repo with eglot.el merged: > https://github.com/bhankas/emacs > > eglot.el file history within merged emacs repo: > https://github.com/bhankas/emacs/commits/master/lisp/progmodes/eglot.el Jumped a bit :) Made another, this time final final correction (properly strip excess before # in URL) and ready for review. git is updated with revision 4, all other links are same. > If all is good, that concludes #2 on Jo=C3=A3o's list. > > Let me know for any corrections and/or improvements. > > Thanks, > Payas Thanks, Payas --