From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#58799: Make winner key sequences repeatable in repeat-mode Date: Thu, 27 Oct 2022 18:18:37 +0200 Message-ID: <878rl1tf36.fsf@gmail.com> References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> <87lep1tmie.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32101"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 27 18:20:06 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo5bv-0007z4-5y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Oct 2022 18:20:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo5bW-0001UM-47; Thu, 27 Oct 2022 12:19:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo5ax-00048S-Oa for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 12:19:15 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo5aw-0006Sa-Nt for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 12:19:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo5aw-0001d8-8Y for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 12:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58799-submit@debbugs.gnu.org id=B58799.16668875276246 (code B ref 58799); Thu, 27 Oct 2022 16:19:02 +0000 Original-Received: (at 58799) by debbugs.gnu.org; 27 Oct 2022 16:18:47 +0000 Original-Received: from localhost ([127.0.0.1]:59086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5ah-0001cg-5l for submit@debbugs.gnu.org; Thu, 27 Oct 2022 12:18:47 -0400 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:35358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5af-0001cN-6l for 58799@debbugs.gnu.org; Thu, 27 Oct 2022 12:18:45 -0400 Original-Received: by mail-wm1-f46.google.com with SMTP id m29-20020a05600c3b1d00b003c6bf423c71so4556430wms.0 for <58799@debbugs.gnu.org>; Thu, 27 Oct 2022 09:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Ya7TyhUjENOr4LbyMeCWf3MfFw3Gmr25hjA6e+dDf74=; b=C5zFQqRmxg41msckaQVbVfBVINnCExdwZ3WhcnDDKYlpzgOlffu2B1fvBauxyT0Wnl ShaA5THqg2GFiOlCQrP+C6aOMFXIUy2D5nD3cXCLM63OG8eWossAq79Cu8nnk2c468mT BeRBCcrNmqIhNc928ptnW/t6DJlYrGmbvR6WDY0tumyfN8LPWWUwPgcpegLtsSVAUbsk 5NJEEOQHC8017BVAsCTTX5i0wR6OamEjlAqIokRc3Pt/KR4tbVhSSYk/xx4qyq0ywv3L U92IK8z58hUacp9uJQkIAtcpZTOQLXFUTEXpkJC7GS5Kmn0Z6OC+FGi7hTJN3YUoXk8i x7PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ya7TyhUjENOr4LbyMeCWf3MfFw3Gmr25hjA6e+dDf74=; b=viMph3o/CONThwk5y/b8UvyQ28NeMQpPsS1uGX7PmD/VL3/nl2tA/wrzeScEemRmC9 zx/RNVvbaJ3M3owDKOybfqQAQ4D57253Ae4HHauEEcJififQiEcI0biAveWoHvZqizT2 uph5OT4CjNPbAq/mUG8Q3DYUGE9YTS5ZWvEIfqe9/EYD7SkhoggPw6wK6Oopk8GtSfW/ o7ZfpDQFZRHGF9ayekeJbpd8rWn6iC0Ak6VGkiruOM+0mhUOgtHQyWZqN34XQZ1o7Mfl x6jIGfSaRpNVrtMCsk1wCKE+c38da31BjafZJWtUcLYwH1ylb7YdRZmfQIryCRoVIFCI DO8g== X-Gm-Message-State: ACrzQf0+iQmjtGaiYN948WNkUl3yZ6ahI2OfpQcNU2PYRJA+EpxzR5I8 uItlzr0yIgJlQYgtQq/1fe4+/hLZ1aE= X-Google-Smtp-Source: AMsMyM6xgnXQr8pd0m+MBcJZHhe/OU2VHwUSCMqPZ5bJTX+B+UsGUqO+dTXe0BuIX5pueKIGfxrqwg== X-Received: by 2002:a05:600c:42c6:b0:3c6:f27e:cac8 with SMTP id j6-20020a05600c42c600b003c6f27ecac8mr6391502wme.175.1666887518886; Thu, 27 Oct 2022 09:18:38 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id bg37-20020a05600c3ca500b003b477532e66sm10790563wmb.2.2022.10.27.09.18.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 09:18:38 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Thu, 27 Oct 2022 09:10:12 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246322 Archived-At: >>>>> On Thu, 27 Oct 2022 09:10:12 -0700, Stefan Kangas said: Stefan> Robert Pluim writes: Stefan> So we should probably make sure that the `defvar-keymap' macro = errors Stefan> out. >>=20 >> That=CA=BCs easy enough (putting it in `define-keymap' would bring o= ut the >> backwards-compatibility police, I think). Probably needs an update to >> the `defvar-keymap' docstring as well. Stefan> `define-keymap' is new in Emacs 29.1, so I think it will be oka= y to Stefan> change it. OK. It=CA=BCs the logical place to put it. >> diff --git a/lisp/keymap.el b/lisp/keymap.el >> index 107565590c..73a9e657fe 100644 >> --- a/lisp/keymap.el >> +++ b/lisp/keymap.el >> @@ -581,6 +581,10 @@ defvar-keymap >> (setq key (pop defs)) >> (pop defs) >> (when (not (eq key :menu)) >> + (when (not (key-valid-p key)) >> + (error >> + "Invalid key '%s' in keymap '%s' (see `key-valid-p')" >> + key variable-name)) >> (if (member key seen-keys) >> (error "Duplicate definition for key '%s' in keymap '%s'" >> key variable-name) Stefan> LGTM. Hmm, in light of the above, maybe the duplicate detection should be moved to `define-keymap' as well. Robert --=20