From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.bugs Subject: bug#58709: 29.0.50; [PATCH] Fallout 307ad21 Date: Mon, 07 Nov 2022 09:39:27 -0800 Message-ID: <878rkmoe9c.fsf@rfc20.org> References: <87czal12oi.fsf@dick> <86tu3t6m59.fsf@mail.linkov.net> <87pmefqcl1.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9908"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58709-done@debbugs.gnu.org, dick , Juri Linkov To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 07 18:40:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1os66k-0002Li-NZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Nov 2022 18:40:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1os66P-0008Jv-8v; Mon, 07 Nov 2022 12:40:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1os66N-0008Gd-Bz for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 12:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1os66M-0002ZP-Qs for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 12:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1os66M-0002ky-FU for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 12:40:02 -0500 Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Nov 2022 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 58709 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 58709@debbugs.gnu.org, matt@rfc20.org, dick.r.chiang@gmail.com Original-Received: via spool by 58709-done@debbugs.gnu.org id=D58709.166784278210561 (code D ref 58709); Mon, 07 Nov 2022 17:40:02 +0000 Original-Received: (at 58709-done) by debbugs.gnu.org; 7 Nov 2022 17:39:42 +0000 Original-Received: from localhost ([127.0.0.1]:35264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os662-0002kG-9f for submit@debbugs.gnu.org; Mon, 07 Nov 2022 12:39:42 -0500 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:44535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os65z-0002jx-Gx for 58709-done@debbugs.gnu.org; Mon, 07 Nov 2022 12:39:40 -0500 Original-Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id D386B100002; Mon, 7 Nov 2022 17:39:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1667842772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sTB8l2pr7LxLguV24Mj1mQIjU8v8I5mMKQdjqYUTXKU=; b=FA3wabyjmkVyDkQLyfLK6WQpg3JcQ+FbM2mlPbozwB4gQx68TLbHDg0iTbNaiBC+6CsVmh Wk6AC0n2UWG3NZ7PM7AJKOuLl6RWDTvM71ZZCgOj4IFUMVoq00wJmeX/9tl6BRNtOwtj// mT3ap3S86sH/fXhj82w51XYKSDfc6aL9sLq27IiG4Xpy8mR0XSaicdiiS09nlVgKg1blOj GKqgpO+/sG/d7ief/ssQcEaCscuZTJPdL8VHOL0+Mz78FGfKXYrKoD52GYtKpWlM18vFRq WK7PtxjofEQxzP/RAbOD2li8AD4JAnYpsNMJxXY0TReAXIuahAQButAVLDXoNw== Original-Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1os65n-000dxD-1u; Mon, 07 Nov 2022 09:39:27 -0800 In-Reply-To: <87pmefqcl1.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 26 Oct 2022 07:16:26 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247291 Archived-At: Philip Kaludercic writes: > Juri Linkov writes: > >>> Hadn't known vc-refresh-state gets into my find-file-hook >>> irregardless. This won't work with git branches in a detached >>> HEAD state. >>>... >>> (defun vc-git-working-revision (_file) >>> "Git-specific version of `vc-working-revision'." >>> (let* ((process-file-side-effects nil) >>> - (commit (vc-git--rev-parse "HEAD" t))) >>> - (or (vc-git-symbolic-commit commit) commit))) >> >> Maybe Philip could comment on this (Cc:ed). >> >> Regarding the commit 307ad21, what I noticed is that after this commit, >> typing 'C-c C-w' (log-edit-generate-changelog-from-diff) in log-edit mode, >> creates temporary buffers with names that contain symbolic revision names >> in their buffer names instead of hash numbers, that looks very strange. > > If that is the case, the change should be reverted, and ideally some > other way could be found to request that vc-working-revision generates a > symbolic reference. Perhaps using a dynamic variable? Closing as the commit in question was reverted by Philip in the commit below. 8fe62b2ab5 (Revert "* lisp/vc/vc-git.el (vc-git--rev-parse): Allow abbreviating commits", 2022-11-06)