From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Date: Tue, 08 Nov 2022 16:08:04 +0100 Message-ID: <878rklh4bv.fsf@gmail.com> References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> <83fsety049.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29238"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , 58909@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 08 16:09:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osQE0-0007Mh-GV for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Nov 2022 16:09:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osQDo-0007Cd-26; Tue, 08 Nov 2022 10:09:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osQDm-0007CA-9z for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 10:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osQDm-0005EM-1x for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 10:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1osQDl-0003Do-T4 for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 10:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2022 15:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166792009812314 (code B ref 58909); Tue, 08 Nov 2022 15:09:01 +0000 Original-Received: (at 58909) by debbugs.gnu.org; 8 Nov 2022 15:08:18 +0000 Original-Received: from localhost ([127.0.0.1]:37954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osQD3-0003CY-PO for submit@debbugs.gnu.org; Tue, 08 Nov 2022 10:08:18 -0500 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:37393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osQCy-0003CH-7h for 58909@debbugs.gnu.org; Tue, 08 Nov 2022 10:08:16 -0500 Original-Received: by mail-wr1-f53.google.com with SMTP id bs21so21454605wrb.4 for <58909@debbugs.gnu.org>; Tue, 08 Nov 2022 07:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=z2DH1EWFWl6lmgLxdFGfDS8TBvjyoknZDRScNqlUQZk=; b=KoBIKJeEB1x6d0CEfcWTC+LYkEt1UbAioETryGQIURjB3zU5uQN0Bq3L+iaDpS09QQ iy3NT4ziDVzCCJWpDPSM3ILM9XAXqFBYvnzdOFef/RTONMEFbkRVg23xF/Dv8C+pYGgJ BZGM8LOOwFbySM+KUouVq5zlVgo5BZAO5P2/gMQhHZfwYRpABQsqCToddt3Nb2dUiD8Z jRSA+jxVubwmyZik8xwwGtmMWa/4jiaaKiYtfXswl0lptD9lz2S+o4oR6RNauC3XhB1q b7O4lNATZRL8ndUZwdi/fbYz5BKwyJOtYlWp+r6JZ+PKofwYrBSwXqcYmFXIs2aPkHdj j6WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z2DH1EWFWl6lmgLxdFGfDS8TBvjyoknZDRScNqlUQZk=; b=nUng1shnYKfjuDliNePbjC9MT8loAPsPYg9FDLrTxTsSkhi0S1fa7yt4l4tyjwR2Or QAmuONEg66215rJGOWrl81UtNWyjPoZLuc+prlLrU5Mry/m8JDssOaijN9xBuPbsZLdq e7Zt9M5bAkoShPa+BOva05ko7eqO75awfLZ2mXf8vetAzeM93r63RLhoinHKLDAkbuHi AbzglALvcp+vAiv+4z52G0cCrvaGNMgS7ApigJ0NqTQiK1jhgU6QG2/LmqEzNJ7Pnw6f Efeg+8z41yIiwDasFTVLWlyXizm0A62dL9u9ZeRRsCKJbPFkhICH3yIbcChiYJFZmxGu OM7Q== X-Gm-Message-State: ACrzQf2w8m6CqKTeXpUr51cdKtyW8kahbuNY4EFx8LhPM5//kFg5491M OrzBT9aXT7eJ3zScAeQ3rQXIDm4vBsM= X-Google-Smtp-Source: AMsMyM4K6Nc05NinHHinNgMhb8/yve+P9Kz6ItcfFRKJcjxZScLRmKZUdwFYCOtgjMsWHNKdTyCfug== X-Received: by 2002:a5d:4572:0:b0:236:ccbe:3513 with SMTP id a18-20020a5d4572000000b00236ccbe3513mr31398522wrc.497.1667920085782; Tue, 08 Nov 2022 07:08:05 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id c2-20020a5d4f02000000b002366553eca7sm10371675wru.83.2022.11.08.07.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 07:08:04 -0800 (PST) In-Reply-To: <83fsety049.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 08 Nov 2022 16:47:02 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247337 Archived-At: >>>>> On Tue, 08 Nov 2022 16:47:02 +0200, Eli Zaretskii said: >> Date: Sun, 6 Nov 2022 12:23:58 -0800 >> Cc: 58909@debbugs.gnu.org >> From: Jim Porter >>=20 >> I also attached a second patch to show an idea I had: since the firs= t=20 >> patch adds a minor-mode keymap for 'server-mode' (and ensures that t= he=20 >> mode is activated whenever the server is running), we could get rid = of=20 >> the server-specific logic from lisp/files.el. Instead of mapping 'C-= x=20 >> C-c' to 'save-buffers-kill-terminal' all the time, Emacs could map i= t to=20 >> 'save-buffers-kill-emacs' by default. Then, when the server is runni= ng,=20 >> remap 'save-buffers-kill-emacs' to 'save-buffers-kill-terminal'. Eli> This means a different binding for "C-x C-c" depending on situatio= n, Eli> and the binding to save-buffers-kill-terminal depending on a minor Eli> mode. Previously, "C-x C-c" would do its job regardless of the mo= de. Eli> I'm not sure this is for the best. I'd be interested to hear from Eli> others, if anyone has an opinion. Rules of Emacs: 1. If it works, don=CA=BCt change it 2. See Rule 1 3. No, really, see Rule 1 I honestly don=CA=BCt see what benefit the minor mode would bring here (and it might just bring new and 'interesting' bugs). Robert --=20