all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Make failure - progmodes/typescript-ts-mode.elc
@ 2022-12-29  9:34 Colin Baxter
  2022-12-29 10:47 ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Colin Baxter @ 2022-12-29  9:34 UTC (permalink / raw)
  To: emacs-devel


On a fresh git pull I have this 'make' failure:

--8<---------------cut here---------------start------------->8---

 ELC      progmodes/typescript-ts-mode.elc

In toplevel form:
progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function definition is void: treesit-query-compile
Makefile:332: recipe for target 'progmodes/typescript-ts-mode.elc' failed
make[4]: *** [progmodes/typescript-ts-mode.elc] Error 1
make[4]: Leaving directory '/home/redknight/git/emacs/lisp'
Makefile:366: recipe for target 'compile-main' failed
make[3]: *** [compile-main] Error 2
make[3]: Leaving directory '/home/redknight/git/emacs/lisp'
Makefile:533: recipe for target 'lisp' failed
make[2]: *** [lisp] Error 2
make[2]: Leaving directory '/home/redknight/git/emacs'
make[2]: Entering directory '/home/redknight/git/emacs'
***
*** "make all" failed with exit status 2.
***
*** You could try to:
*** - run "make bootstrap", which might fix the problem
*** - run "make V=1", which displays the full commands invoked by make,
***   to further investigate the problem
***

--8<---------------cut here---------------end--------------->8---

I have tried both make bootstrap <RET>, and make extraclean <RET>
followed by make <RET>, but to no avail.

I am on Linux bluestar 4.9.0-19-686-pae #1 SMP Debian 4.9.320-2
(2022-06-30) i686 GNU/Linux.

Best wishes,

Colin Baxter.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Make failure - progmodes/typescript-ts-mode.elc
  2022-12-29  9:34 Make failure - progmodes/typescript-ts-mode.elc Colin Baxter
@ 2022-12-29 10:47 ` Eli Zaretskii
  2022-12-29 12:26   ` Colin Baxter
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2022-12-29 10:47 UTC (permalink / raw)
  To: m43cap; +Cc: emacs-devel

> From: Colin Baxter <m43cap@yandex.com>
> Date: Thu, 29 Dec 2022 09:34:36 +0000
> 
> 
> On a fresh git pull I have this 'make' failure:
> 
> --8<---------------cut here---------------start------------->8---
> 
>  ELC      progmodes/typescript-ts-mode.elc
> 
> In toplevel form:
> progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function definition is void: treesit-query-compile
> Makefile:332: recipe for target 'progmodes/typescript-ts-mode.elc' failed
> make[4]: *** [progmodes/typescript-ts-mode.elc] Error 1
> make[4]: Leaving directory '/home/redknight/git/emacs/lisp'
> Makefile:366: recipe for target 'compile-main' failed
> make[3]: *** [compile-main] Error 2
> make[3]: Leaving directory '/home/redknight/git/emacs/lisp'
> Makefile:533: recipe for target 'lisp' failed
> make[2]: *** [lisp] Error 2
> make[2]: Leaving directory '/home/redknight/git/emacs'
> make[2]: Entering directory '/home/redknight/git/emacs'
> ***
> *** "make all" failed with exit status 2.
> ***
> *** You could try to:
> *** - run "make bootstrap", which might fix the problem
> *** - run "make V=1", which displays the full commands invoked by make,
> ***   to further investigate the problem
> ***
> 
> --8<---------------cut here---------------end--------------->8---
> 
> I have tried both make bootstrap <RET>, and make extraclean <RET>
> followed by make <RET>, but to no avail.
> 
> I am on Linux bluestar 4.9.0-19-686-pae #1 SMP Debian 4.9.320-2
> (2022-06-30) i686 GNU/Linux.

Doesn't happen here.  However, I'm guessing that your build is without
tree-sitter.  Please make a point of using report-emacs-bug, so that
we won't need to guess.

Yuan, this code in js.el:

  (defvar js--treesit-lhs-identifier-query
    (treesit-query-compile 'javascript '((identifier) @id
					 (property_identifier) @id))
    "Query that captures identifier and query_identifier.")

cannot unconditionally call treesit-query-compile, because it will
fail to load in a build without tree-sitter.  (It also need a
declare-function.)

The above failure is caused because typescript-ts-mode.el requires
js.el.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Make failure - progmodes/typescript-ts-mode.elc
  2022-12-29 10:47 ` Eli Zaretskii
@ 2022-12-29 12:26   ` Colin Baxter
  2022-12-29 19:35     ` Yuan Fu
  0 siblings, 1 reply; 5+ messages in thread
From: Colin Baxter @ 2022-12-29 12:26 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

    >> From: Colin Baxter <m43cap@yandex.com> Date: Thu, 29 Dec 2022
    >> 09:34:36 +0000
    >> 
    >> 
    >> On a fresh git pull I have this 'make' failure:
    >> 
    >> --8<---------------cut here---------------start------------->8---
    >> 
    >> ELC progmodes/typescript-ts-mode.elc
    >> 
    >> In toplevel form: progmodes/typescript-ts-mode.el:31:2: Error:
    >> Symbol’s function definition is void: treesit-query-compile
    >> Makefile:332: recipe for target
    >> 'progmodes/typescript-ts-mode.elc' failed make[4]: ***
    >> [progmodes/typescript-ts-mode.elc] Error 1 make[4]: Leaving
    >> directory '/home/redknight/git/emacs/lisp' Makefile:366: recipe
    >> for target 'compile-main' failed make[3]: *** [compile-main]
    >> Error 2 make[3]: Leaving directory
    >> '/home/redknight/git/emacs/lisp' Makefile:533: recipe for target
    >> 'lisp' failed make[2]: *** [lisp] Error 2 make[2]: Leaving
    >> directory '/home/redknight/git/emacs' make[2]: Entering directory
    >> '/home/redknight/git/emacs' *** *** "make all" failed with exit
    >> status 2.  *** *** You could try to: *** - run "make bootstrap",
    >> which might fix the problem *** - run "make V=1", which displays
    >> the full commands invoked by make, *** to further investigate the
    >> problem ***
    >> 
    >> --8<---------------cut here---------------end--------------->8---
    >> 
    >> I have tried both make bootstrap <RET>, and make extraclean <RET>
    >> followed by make <RET>, but to no avail.
    >> 
    >> I am on Linux bluestar 4.9.0-19-686-pae #1 SMP Debian 4.9.320-2
    >> (2022-06-30) i686 GNU/Linux.

    > Doesn't happen here.  However, I'm guessing that your build is
    > without tree-sitter.  Please make a point of using

Yes, I don't compile --with-tree-sitter. I don't have the tree-sitter
libraries.

    > report-emacs-bug, so that we won't need to guess.

Ok, sorry.


Best wishes,



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Make failure - progmodes/typescript-ts-mode.elc
  2022-12-29 12:26   ` Colin Baxter
@ 2022-12-29 19:35     ` Yuan Fu
  2022-12-30  9:42       ` Colin Baxter
  0 siblings, 1 reply; 5+ messages in thread
From: Yuan Fu @ 2022-12-29 19:35 UTC (permalink / raw)
  To: Colin Baxter; +Cc: Eli Zaretskii, emacs-devel



> On Dec 29, 2022, at 4:26 AM, Colin Baxter <m43cap@yandex.com> wrote:
> 
>>>>>> Eli Zaretskii <eliz@gnu.org> writes:
> 
>>> From: Colin Baxter <m43cap@yandex.com> Date: Thu, 29 Dec 2022
>>> 09:34:36 +0000
>>> 
>>> 
>>> On a fresh git pull I have this 'make' failure:
>>> 
>>> --8<---------------cut here---------------start------------->8---
>>> 
>>> ELC progmodes/typescript-ts-mode.elc
>>> 
>>> In toplevel form: progmodes/typescript-ts-mode.el:31:2: Error:
>>> Symbol’s function definition is void: treesit-query-compile
>>> Makefile:332: recipe for target
>>> 'progmodes/typescript-ts-mode.elc' failed make[4]: ***
>>> [progmodes/typescript-ts-mode.elc] Error 1 make[4]: Leaving
>>> directory '/home/redknight/git/emacs/lisp' Makefile:366: recipe
>>> for target 'compile-main' failed make[3]: *** [compile-main]
>>> Error 2 make[3]: Leaving directory
>>> '/home/redknight/git/emacs/lisp' Makefile:533: recipe for target
>>> 'lisp' failed make[2]: *** [lisp] Error 2 make[2]: Leaving
>>> directory '/home/redknight/git/emacs' make[2]: Entering directory
>>> '/home/redknight/git/emacs' *** *** "make all" failed with exit
>>> status 2.  *** *** You could try to: *** - run "make bootstrap",
>>> which might fix the problem *** - run "make V=1", which displays
>>> the full commands invoked by make, *** to further investigate the
>>> problem ***
>>> 
>>> --8<---------------cut here---------------end--------------->8---
>>> 
>>> I have tried both make bootstrap <RET>, and make extraclean <RET>
>>> followed by make <RET>, but to no avail.
>>> 
>>> I am on Linux bluestar 4.9.0-19-686-pae #1 SMP Debian 4.9.320-2
>>> (2022-06-30) i686 GNU/Linux.
> 
>> Doesn't happen here.  However, I'm guessing that your build is
>> without tree-sitter.  Please make a point of using
> 
> Yes, I don't compile --with-tree-sitter. I don't have the tree-sitter
> libraries.

Sorry about that. I fixed js.el. I’ve setup a without-tree-sitter build, so I’ll be able to catch these errors next time.

Yuan


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Make failure - progmodes/typescript-ts-mode.elc
  2022-12-29 19:35     ` Yuan Fu
@ 2022-12-30  9:42       ` Colin Baxter
  0 siblings, 0 replies; 5+ messages in thread
From: Colin Baxter @ 2022-12-30  9:42 UTC (permalink / raw)
  To: Yuan Fu; +Cc: Eli Zaretskii, emacs-devel

>>>>> Yuan Fu <casouri@gmail.com> writes:

    >> On Dec 29, 2022, at 4:26 AM, Colin Baxter <m43cap@yandex.com> wrote:
    >> 
    >>>>>>> Eli Zaretskii <eliz@gnu.org> writes:
    >> 
    >>>> From: Colin Baxter <m43cap@yandex.com> Date: Thu, 29 Dec 2022
    >>>> 09:34:36 +0000
    >>>> 
    >>>> 
    >>>> On a fresh git pull I have this 'make' failure:
    >>>> 
    >>>> --8<---------------cut
    >>>> here---------------start------------->8---
    >>>> 
    >>>> ELC progmodes/typescript-ts-mode.elc
    >>>> 
    >>>> In toplevel form: progmodes/typescript-ts-mode.el:31:2: Error:
    >>>> Symbol’s function definition is void: treesit-query-compile
    >>>> Makefile:332: recipe for target
    >>>> 'progmodes/typescript-ts-mode.elc' failed make[4]: ***
    >>>> [progmodes/typescript-ts-mode.elc] Error 1 make[4]: Leaving
    >>>> directory '/home/redknight/git/emacs/lisp' Makefile:366: recipe
    >>>> for target 'compile-main' failed make[3]: *** [compile-main]
    >>>> Error 2 make[3]: Leaving directory
    >>>> '/home/redknight/git/emacs/lisp' Makefile:533: recipe for
    >>>> target 'lisp' failed make[2]: *** [lisp] Error 2 make[2]:
    >>>> Leaving directory '/home/redknight/git/emacs' make[2]: Entering
    >>>> directory '/home/redknight/git/emacs' *** *** "make all" failed
    >>>> with exit status 2.  *** *** You could try to: *** - run "make
    >>>> bootstrap", which might fix the problem *** - run "make V=1",
    >>>> which displays the full commands invoked by make, *** to
    >>>> further investigate the problem ***
    >>>> 
    >>>> --8<---------------cut
    >>>> here---------------end--------------->8---
    >>>> 
    >>>> I have tried both make bootstrap <RET>, and make extraclean
    >>>> <RET> followed by make <RET>, but to no avail.
    >>>> 
    >>>> I am on Linux bluestar 4.9.0-19-686-pae #1 SMP Debian 4.9.320-2
    >>>> (2022-06-30) i686 GNU/Linux.
    >> 
    >>> Doesn't happen here.  However, I'm guessing that your build is
    >>> without tree-sitter.  Please make a point of using
    >> 
    >> Yes, I don't compile --with-tree-sitter. I don't have the
    >> tree-sitter libraries.

    > Sorry about that. I fixed js.el. I’ve setup a without-tree-sitter
    > build, so I’ll be able to catch these errors next time.

    > Yuan
    
Thank you, Yuan. The master branch now builds for me successfully.

Best wishes,

Colin Baxter.



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-12-30  9:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-29  9:34 Make failure - progmodes/typescript-ts-mode.elc Colin Baxter
2022-12-29 10:47 ` Eli Zaretskii
2022-12-29 12:26   ` Colin Baxter
2022-12-29 19:35     ` Yuan Fu
2022-12-30  9:42       ` Colin Baxter

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.