From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60623: 30.0.50; Add forward-sentence with tree sitter support Date: Sun, 08 Jan 2023 20:19:58 +0100 Message-ID: <878ricu941.fsf@thornhill.no> References: <87o7ratva2.fsf@thornhill.no> <86bkn9whgl.fsf@mail.linkov.net> <86k01xue5z.fsf@mail.linkov.net> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35905"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "60623@debbugs.gnu.org" <60623@debbugs.gnu.org>, "casouri@gmail.com" , "eliz@gnu.org" , Drew Adams , "monnier@iro.umontreal.ca" To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 08 20:21:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEbEO-00098S-12 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Jan 2023 20:21:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEbE7-0002bJ-8G; Sun, 08 Jan 2023 14:21:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEbE6-0002Yv-D7 for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 14:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEbE5-00038F-SZ for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 14:21:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEbE5-00066P-JX for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 14:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jan 2023 19:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60623 X-GNU-PR-Package: emacs Original-Received: via spool by 60623-submit@debbugs.gnu.org id=B60623.167320560723370 (code B ref 60623); Sun, 08 Jan 2023 19:21:01 +0000 Original-Received: (at 60623) by debbugs.gnu.org; 8 Jan 2023 19:20:07 +0000 Original-Received: from localhost ([127.0.0.1]:34730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEbDD-00064s-3f for submit@debbugs.gnu.org; Sun, 08 Jan 2023 14:20:07 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:19950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEbD8-00064Q-AT for 60623@debbugs.gnu.org; Sun, 08 Jan 2023 14:20:05 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1673205600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ccgu7SMa4pt4qFz4b7KRXagxHeiC/d6WngZK55H9olE=; b=nvmvHL+ZCVldo/RZ46YA7+HyrvvxS/SfLfa4l3ARrWy5ZkT+WMLITJcL5UStuJKc9dHhyG 6YyUyQSKO3ZDx3EdiwqQWCh0i0G9gacWkZ5MrwjeHmdXoQflDm//oAKA8lskGpbX4+WxqO bYsaXu5bMEsz80dMomo2VyW3fXkyUnZciN3IXtdkOiH5KwdaAaHPHSAahjbOvqbRekCKmF CxIYYueAXVzz+LrC1PRIFPov2SIxq48b1b8HQMqN/5TDCQtYHIuAPddycsZ6/FO3/k2m+y ihLQxS+r3eNwTemasZaXec6AosIyPyzukNA0Q25MjGXBBw4iG8WXuBXyvPFXXQ== In-Reply-To: <86k01xue5z.fsf@mail.linkov.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252955 Archived-At: Juri Linkov writes: >>>> >A good practice is to name such a function >>>> >e.g. forward-sentence-default-function. >>>> >>>> Is this practice used anywhere else? Iirc >>>> forward-sexp-function doesn't follow that >>>> practice. >>> >>>On the other hand, if the value must always >>>be a function, then having "-default-" in >>>the name makes sense. >> >> So is this to be considered an improvement to forward-sexp too, then? > > Sorry, I can't find where a lambda is set to forward-sexp-function. > I only see this: > > (defvar forward-sexp-function nil > > But if it will be set to a function later, it would be nice > to define a default function as well. I meant the way we did with 'transpose-sexps', where there now is a 'transpose-sexps-function' variable containing the factored-out earlier implementation. And by if "this is an improvement" I meant declaring a specific defun as the default value for the defvar in question. Maybe I should add the same change which is now developing here there too. What do you think? Theo