From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 4a8891a462: * etc/NEWS: Mention incompatible changes in 'outline-minor-mode-cycle-map'. Date: Mon, 16 Jan 2023 16:02:38 +0100 Message-ID: <878ri2ed4h.fsf@gmail.com> References: <167346587385.21119.11842722402918987249@vcs2.savannah.gnu.org> <20230111193754.33EF3C00A7F@vcs2.savannah.gnu.org> <87fscaeg5s.fsf@gmail.com> <83lem24kia.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6916"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 16 16:03:26 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHR1B-0001c5-NE for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Jan 2023 16:03:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHR0Y-0000zF-27; Mon, 16 Jan 2023 10:02:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHR0V-0000wf-2s for emacs-devel@gnu.org; Mon, 16 Jan 2023 10:02:44 -0500 Original-Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHR0T-0003nR-EW; Mon, 16 Jan 2023 10:02:42 -0500 Original-Received: by mail-wm1-x333.google.com with SMTP id h12-20020a05600c314c00b003da50afcb33so3856968wmo.4; Mon, 16 Jan 2023 07:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lwVXt9oxC2WbAcSgvBrRi2hDxMf9O+/Z3jliCcF2f68=; b=C0HCvWzvhmoGnx1qQGLg9XkN5KVtHjSMck+XuLfEKZfDgVtcCmzZVWLML7NxLu526K +vBKdgJ0wLSAHOMpSe/90m0Ei5IJ9SW/aTKGio3xRbSurNKudPFqyMTDtRG9tV+2sse/ 48wYGcbBl4gHMp3WMHcwbBRipF7SMdxBq+Up6vCv3l7lorxJONuOv7bxuSZC/OdxBad1 ddNE2bRYjGS/JclneJY29fnz0A54Kbl4HB0PU4+ybc5/jUYeoQhHUSIifYr8F2V15K28 wXBwsVptkmUgSFl64VC34rax6j0gTULsgt8kRGDbUIE79LO6XSkaFYgcmgoQmk74eVZ4 zmqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lwVXt9oxC2WbAcSgvBrRi2hDxMf9O+/Z3jliCcF2f68=; b=deo3vzn77/VT1wrmy97vihMd9xwJxJIFo6yWI3V4W/ceATlU12qrRDtrInyZgzVD9W KBDVjbrwQPfUMmgRKM76f6qYjfxUXuN67vlySe46QbV10h/WHZN09ix9BsZVq3Z9ejex Tn8OreWylizlfnkcYLriy3c+k2ghdUcjbjw5msWRn/6rKfDvDZD8+wlcnM2pz2+yLJEn sAKSE+VGXa7whsA3GWPM5xs+Z/6DOdwIhUpL91kRgwVY1J9aJiY69gxTazAutAaXDRje pXbh0fjn3Q9zaPMmxHlXiAMBHWl0Y5j86WVFw6+fUSmxcaQx2x3UGr1fiTFHuAmkI73T WNkA== X-Gm-Message-State: AFqh2ko3hxFS++8vvp2PYkPnv3RSm1Sxx10zbHxE5axq35HKp93zF3My 1UB0AOyys1dWGAGvjFGOFkm24w3SPks= X-Google-Smtp-Source: AMrXdXtvIx2TAZDeUOK2M5tDAm6eNfH3aH53xHWLzfyQrPHPk1EEKBViEfa8Y9lcmtFsgcoP/k7PLw== X-Received: by 2002:a05:600c:4d21:b0:3d2:2a72:2573 with SMTP id u33-20020a05600c4d2100b003d22a722573mr67568084wmp.11.1673881359458; Mon, 16 Jan 2023 07:02:39 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id e13-20020a05600c218d00b003daf672a616sm5554193wme.22.2023.01.16.07.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 07:02:38 -0800 (PST) In-Reply-To: <83lem24kia.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Jan 2023 16:33:17 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=rpluim@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302459 Archived-At: >>>>> On Mon, 16 Jan 2023 16:33:17 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Juri Linkov >> Date: Mon, 16 Jan 2023 14:57:03 +0100 >>=20 >> >>>>> On Wed, 11 Jan 2023 14:37:54 -0500 (EST), Juri Linkov said: >>=20 Juri> branch: emacs-29 Juri> commit 4a8891a462e41e81a5232810b67d9d85f79bc515 Juri> Author: Juri Linkov Juri> Commit: Juri Linkov >>=20 Juri> * etc/NEWS: Mention incompatible changes in 'outline-minor-mode-c= ycle-map'. >>=20 Juri> * lisp/outline.el (outline-minor-mode-cycle--bind): Juri> Add docstring (bug#60426). Juri> (outline-minor-mode-cycle--bind): Default 'map' to Juri> 'outline-minor-mode-cycle-map'. Juri> (outline-minor-mode-cycle-map): Improve docstring. Juri> (outline-minor-mode): Move margin-cycling keys to Juri> 'outline-minor-mode-cycle-map'. Juri> --- >>=20 >> Juri/Eli, any objection to putting something like the following in >> emacs-29? That would make it easier to add heading-specific bindings >> in NEWS mode, which I=CA=BCd do in master. It also avoids creating a >> separate keymap for each heading. Eli> I don't think I understand the problem you are trying to solve, and Eli> why this particular solution. Please tell more. In outline-mode and modes derived from it, there are various bindings that work at the start of headings (and in buttons that could be inserted depending on the value of `outline-minor-mode-use-buttons=CA=BC), such as "RET" for `outline-cycle'. Adding more bindings there is a pain, since the bindings are done using a separate anonymous keymap on each per-heading overlay, which means iterating over all the overlays in order to make changes. The patch I sent changes that to use a named keymap, so only the named keymap needs to be updated or `setq-local'=CA=BCd before invoking `outline-mode'. (and what I really want to do is add 'n' and 'p' into that map, which improves the speed at which I can proofread NEWS.) Robert --=20