From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29 Date: Thu, 16 Mar 2023 12:20:22 +0000 Message-ID: <878rfw51mh.fsf@gmail.com> References: <87wn3jue1q.fsf@gmail.com> <87edpqjqsv.fsf@gmx.de> <874jqmjl0s.fsf@gmx.de> <875yb1pxai.fsf@miha-pc> <87ttykj45i.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26947"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62194@debbugs.gnu.org, miha@kamnitnik.top To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 16 13:19:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcmZt-0006nE-Cv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Mar 2023 13:19:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcmZX-0002IZ-AL; Thu, 16 Mar 2023 08:19:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcmZS-0002I4-He for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 08:19:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcmZS-0007g8-8o for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 08:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pcmZR-00069V-ME for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 08:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Mar 2023 12:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62194 X-GNU-PR-Package: emacs Original-Received: via spool by 62194-submit@debbugs.gnu.org id=B62194.167896911223601 (code B ref 62194); Thu, 16 Mar 2023 12:19:01 +0000 Original-Received: (at 62194) by debbugs.gnu.org; 16 Mar 2023 12:18:32 +0000 Original-Received: from localhost ([127.0.0.1]:41437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcmYy-00068a-2f for submit@debbugs.gnu.org; Thu, 16 Mar 2023 08:18:32 -0400 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:47079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcmYw-00068K-D3 for 62194@debbugs.gnu.org; Thu, 16 Mar 2023 08:18:30 -0400 Original-Received: by mail-wr1-f44.google.com with SMTP id r29so1310275wra.13 for <62194@debbugs.gnu.org>; Thu, 16 Mar 2023 05:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678969104; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=46Nnorxg10Je/v7uA9r7JFy9V7N27HeTu9egnbrNA4w=; b=pjL+CC2kTmnIZKw2KtFUofGZKZxEhn3vOnzc2kJtKhWaVEMvLU/ROV7nKizqx5zZqR 8J0Bnl6V9La4QXUifLC+kgcE7yfbcxtzTRnnMRBD4Agr5x2iOKA+FpicFGTFAmEW/4cy 8lVxpH1fjrquZj9IKt/pF2yFE31LCD5wNS5wyj5ePijLL7a3hTtZucLiBNXcZoGV3C3K N+1DUVDWeQA26+orC2FC0Tdm99fT43mEkQ1MOd5wdE+iyFY/s+Frhlcmi/gE+R4IaHBc rKJwmk6MIDcOQyxZc/hEcjj4ePqHXirGdPTMxvVufI6kXJOSVcPjyhL+48v27OgWvOm4 PL2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678969104; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=46Nnorxg10Je/v7uA9r7JFy9V7N27HeTu9egnbrNA4w=; b=G9N5C47RYI69IYCnTNCR+9+HykOdPCOijWiW3f/FbR2HImZzJintTskNEpj5xezeYk NczKpGC4HPf6wZIrnueqpDzTynlHw5UgmK+lk//i/9YSN9y+YbsuuPXKZY4D8rRYOp1o m7KoCjFK5aLRdmNHh4kTepVa9scxClc0hYukDMEI5jiG/bDiawEs3k7BxNLmb4D2q5W+ YDxxzRz7Fu5GydmIT91ur4YkcUTzUEiwRETXD98aKa20ciu9BZN+IYOlY2JRJHkYoTI7 R7a+dibKXCox5jdvcLCnLxHkGNOMYeCHhYC0inN6AIewtx6WLwyRm4Yw/DOurI09f/Os tBrg== X-Gm-Message-State: AO0yUKU90P0VzzrhRLZu89+cvDI6QcKuvWZsXKuwlwOZWC7K76TVCt5u 2biJkapWIvQ8FQxgZte/fE76/jpHLWk= X-Google-Smtp-Source: AK7set+rqu9mR6eMjx9ot8nQ1yg9p3CusuhmLcj/UipaRuHb1KgHAqqgnBARGwbWxfw3ySWSwYeqWg== X-Received: by 2002:a5d:4d05:0:b0:2ce:b781:b1e5 with SMTP id z5-20020a5d4d05000000b002ceb781b1e5mr4256667wrt.19.1678969103825; Thu, 16 Mar 2023 05:18:23 -0700 (PDT) Original-Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id d16-20020a5d5390000000b002cea392f000sm7052200wrv.69.2023.03.16.05.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 05:18:23 -0700 (PDT) In-Reply-To: <87ttykj45i.fsf@gmx.de> (Michael Albinus's message of "Thu, 16 Mar 2023 13:02:01 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258014 Archived-At: Michael Albinus writes: > Jo=C3=A3o T=C3=A1vora writes: > > Hi, > >> I'm "against" this too, but hard facts here trump arguments and opinion. >> This is exactly what fixes the ControlMaster hang, that's well understoo= d, >> and is really intended. It brings about some other failures but I've just >> confirmed that if you put >> >> (while (accept-process-output p 0 nil t)) >> >> then all's well. >> >> Of course, it's only _one_ of the ways to fix the problem. If you have = another >> more elegant one, but I don't know if signals is a great one. I'd guess >> SIGWINCH to be somewhat limited in platform support, right? > > I'm also against using SIGWINCH at this point. It isn't portable, and it > isn't even known whether it is needed always. The proposed patch wraps > it by > > (when (and (not result) (process-get proc 'shared-socket)) > > But the reason why result is nil could be simply the case that the > remote side hasn't something to tell yet, and we need to wait. > > And this would complicate the scenario further. We have already a very > fragile tramp-accept-process-output, which has changed again and again > ove the last 20 years. I *really* would like to see a simple and robust > implementation. > > My attempt with the additional process property `shared-socket' has > failed, and I've reverted it. > > Pushed to master. The Eglot Tramp tests pass now, so I recommend to > close this bug. Michael, now you've brought back the Eglot/Tramp hang of bug#61350! Really Michael, please consider reverting 0330cff65ae (your latest) and 54ef338ba36 (from two days ago), and going back to the simpler version that you originally proposed, with just the 'while' added there. It fixes all this mess. _Then_ we can go get to thinking about the "simple and robust" implementation. Jo=C3=A3o