From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62687: [PATCH] Eglot: eglot--sig-info: Show SigInfo Docs if Markup; fix regex for highlighting; etc Date: Sat, 08 Apr 2023 23:31:19 +0100 Message-ID: <878rf2gg5k.fsf@gmail.com> References: <875yaanfuv.fsf@posteo.de> <87fs9bmg1j.fsf@posteo.de> <87cz4egnqa.fsf@gmail.com> <87bkjym6ic.fsf@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17025"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62687@debbugs.gnu.org To: Mekeor Melire Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 09 00:30:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plH4g-0004KS-MT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Apr 2023 00:30:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plH4T-0006Ee-Gl; Sat, 08 Apr 2023 18:30:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plH4O-0006EO-0N for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 18:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plH4N-00044B-Ou for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 18:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plH4N-0001OF-5O for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 18:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Apr 2023 22:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62687 X-GNU-PR-Package: emacs Original-Received: via spool by 62687-submit@debbugs.gnu.org id=B62687.16809929665259 (code B ref 62687); Sat, 08 Apr 2023 22:30:03 +0000 Original-Received: (at 62687) by debbugs.gnu.org; 8 Apr 2023 22:29:26 +0000 Original-Received: from localhost ([127.0.0.1]:59785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plH3m-0001Ml-3m for submit@debbugs.gnu.org; Sat, 08 Apr 2023 18:29:26 -0400 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:41608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plH3i-0001MU-VA for 62687@debbugs.gnu.org; Sat, 08 Apr 2023 18:29:24 -0400 Original-Received: by mail-wm1-f46.google.com with SMTP id n19-20020a05600c501300b003f064936c3eso6021074wmr.0 for <62687@debbugs.gnu.org>; Sat, 08 Apr 2023 15:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680992957; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XkrWdNLnZE8l9HyHw4pxCnN+NTsEiDfw2FTijMEFEUs=; b=dpCYGkjChllqrnlt7/uWxic80NuXHnIMsDO4cU2Lum3sGeilDgcrQ/j0n1FOdayCwI kGXRNyyZdP3QzJLd8ecErOOq+G8/YcTXVG9SJLIkgoHYczID2R81iu+MzH8+fB+0qXrV 1SeZp24ctMxnQY/9qzNeL7cOnESGXtGO4vzC5k++NC4g6T3NeUkykZbD5gz0ZELR6Uaa 7WN/g3KRbBijWaZ9b/hsRWiUB7BbRiyAye8zJeyeS0r+7Kf5hm5HQIbbSP/JWoHaUfCg cokRbmrRt7aWAMSGJQ2i2htmCHw+AtDxg2nle3+iVdwYAtReOKz1ZD+LziGS/CGTRrlA lIcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680992957; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XkrWdNLnZE8l9HyHw4pxCnN+NTsEiDfw2FTijMEFEUs=; b=KOAHZb0TKG48oY2CTpOxtAtfJkhfqDPowH16W3TnWTwvkz5Rmi0356yR/6PkaZXEps Z+MDVNeoTy005ORkeRupfKNfZxPGcJt0Syp9wrT932AUrmzXj9bUFuMusOExS1cr28kB Elo3peVSRKPdmvWfKQStw2TrYmLxzzUz+fCwLrZbVZIgZkhF25c4gQ6KKRU6JJlhGiO0 IVp7wJQhdjONfyhKt2q7wXJgx+upcxmzWa5JvBo4rD8s8gVCOEYbs3dUPRn2g1bidwXV zroW+vU2OL13Hf6PmXr9+dKMOXvt3p61zwDtCDGbKi303j9c9BIy4hVSnflBDPHx5Bb4 dgwg== X-Gm-Message-State: AAQBX9czQyII30ZjNwGkMb58B2JCTAV6D6iTskfgl7UjUGwuiiuebbmm Us8hcGt34jHWfVs9CzqNm6myTm+sD10= X-Google-Smtp-Source: AKy350aefvW7ovDiiW6Nz1bxme3bcGE23kd2jCcy3iPcPT7uusIYPBRskNQy7lrRDkJOt7EjxcISiw== X-Received: by 2002:a7b:cbc7:0:b0:3f0:3a9a:517f with SMTP id n7-20020a7bcbc7000000b003f03a9a517fmr4706227wmi.29.1680992956626; Sat, 08 Apr 2023 15:29:16 -0700 (PDT) Original-Received: from krug ([87.196.73.56]) by smtp.gmail.com with ESMTPSA id 16-20020a05600c029000b003ef71d541cbsm8958674wmk.1.2023.04.08.15.29.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Apr 2023 15:29:16 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 8 Apr 2023 22:12:31 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259498 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Thank you! That commit indeed makes Eglot show=20 > "SignatureInformation"'s "documentation" field even if it's of=20 > type MarkupContent. So it solves this main issue. > > Unfortunately, that commit causes Eglot to not show the=20 > "ParameterInformation"'s "documenation" field. I propose to show=20 > both the SigInfo- and the ParamInfo-documentation, whenever=20 > possible. (To be more precise: First, the SigInfo-doc should be=20 > shown, if non-nil. Then, the ParamInfo-doc should be shown, if=20 > non-nil.) What do you think? I did more changes to master taking that into account. See e33c0a549153fa3894f3b5e9c5e42ce07a1a68c7 and tell me if there's any more stuff missing. > Ok, i took it out, because I didn't find any server that used > it. Pylsp uses it, but the doc is always the empty string. Does your > TS server use it? Did you get around to providing the event log i > asked for? Never mind, I downloaded typescript-language-server and checked it out myself. Jo=C3=A3o