bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path

[Philip Kaludercic <philipk@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: artscan@list.ru,  monnier@iro.umontreal.ca,  63757@debbugs.gnu.org
>> Date: Sun, 04 Jun 2023 11:39:53 +0000
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > Is that a reverse diff or something?  The code we have now already
>> > does sort the list...
>> 
>> No, the current code passes a non-nil NOSORT flag to `directory-files',
>> which inhibits sorting?

I'm sorry, that was the wrong patch -.-


[-- Attachment #2: Type: text/plain, Size: 561 bytes --]

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index de5108430aa..fdc09a939be 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -739,7 +739,7 @@ package-load-all-descriptors
 updates `package-alist'."
   (dolist (dir (cons package-user-dir package-directory-list))
     (when (file-directory-p dir)
-      (dolist (pkg-dir (directory-files dir t "\\`[^.]" t))
+      (dolist (pkg-dir (directory-files dir t "\\`[^.]"))
         (when (file-directory-p pkg-dir)
           (package-load-descriptor pkg-dir))))))
 

[-- Attachment #3: Type: text/plain, Size: 173 bytes --]


(I attached the *vc-diff* buffer, but before sending the message I
invoked vc-diff again which modified the buffer contents.  Should have
just copied the diff manually...)