From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Sat, 24 Jun 2023 00:18:48 +0200 Message-ID: <878rc9rfef.fsf@gmx.net> References: <87v8frihny.fsf@gmx.net> <837cs7we2z.fsf@gnu.org> <47e13491-1654-db22-2f8b-f12195953232@gmail.com> <87o7lhrm2x.fsf@gmx.net> <87edm3tg57.fsf@gmx.net> <613827fd-46e8-b8e8-dd91-1539f007a099@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7714"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Stefan Monnier , 64046@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 24 00:20:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCp8k-0001h5-MV for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Jun 2023 00:20:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCp8Q-0007oh-Jc; Fri, 23 Jun 2023 18:20:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCp8N-0007o0-N1 for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 18:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCp8M-0007mR-PD for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 18:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qCp8M-0005TE-Dc for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 18:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jun 2023 22:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs Original-Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168755874620954 (code B ref 64046); Fri, 23 Jun 2023 22:20:02 +0000 Original-Received: (at 64046) by debbugs.gnu.org; 23 Jun 2023 22:19:06 +0000 Original-Received: from localhost ([127.0.0.1]:39672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCp7S-0005Rt-1N for submit@debbugs.gnu.org; Fri, 23 Jun 2023 18:19:06 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:48481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCp7P-0005RO-Cs for 64046@debbugs.gnu.org; Fri, 23 Jun 2023 18:19:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1687558733; x=1688163533; i=stephen.berman@gmx.net; bh=p2E7iJ0wUo8W1NHct1DNAsfsNETVtHRQr2263n634p4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=asQVaS8m+6L5hY3U4Rcive8llgeKULZcJSZztiCc1OUCR+AICv1a0GAZD2n1L7eX//zYBbR RlbHwvHz7p8CadaK4piv0sGeBaTwT62c8vZfraZqfeleie/UYsLNkzDqmUkmASBFUrN8dwAkU YM1rUVJVuJ+/6ZuagLghPlaXgkmOjxVjbuJg4dGmZRcuJfcpz4kmy885z9ZuUsrY/jjOfIADb ppxgpfPKWhHkvUMNGiTgMUwvn/unQgghSg6yViBXPpj7S0+kiLuELLBwjm0hgT2aE0rLQ4OQK tDhQCiBV+x2WGaEvve0ODFjtQ7UFOy/QzZzkVuc0FuOsXcorAsSg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([89.246.37.248]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MTiPv-1qehEm3AQH-00U3rF; Sat, 24 Jun 2023 00:18:53 +0200 In-Reply-To: <613827fd-46e8-b8e8-dd91-1539f007a099@gmail.com> (Mauro Aranda's message of "Thu, 22 Jun 2023 19:59:26 -0300") X-Provags-ID: V03:K1:yW39zx2JonSJ0oMEfWf8Xg1LaXhvGoKkB4TZQpDOUaZSEAgKpV9 HFOeSH1mgXRQEufCS/D1XGUqEmT31qCiRf5SlcR2HVy1Fd67vpn3iLfC6pehtZANhWs/lAq aDLwacYjYBFeSwEusT1D56VVCDzSbZ5gAnIKO/+vIaYsuGkIIbxHUZgM0X/BfpF1o+L2R4a wh+efEdy74hyNwlAjy7sQ== UI-OutboundReport: notjunk:1;M01:P0:XlgTJ/J3ZHQ=;ZKcleRHEaD61DQD98oR9CQgAv2L xti2NQTOko2/Wc5d6JoQXZF/dH0u8C9UaS7iz+NbK0HRQHjgQ/Jg8WFdi80e69nTbUpPc11T8 Nn3kTe5rvKwO0sS2UdXxet1YQ7On2LuxR91LKPpytcd6fd5oJYu8lbxrfiqyCby/JS+FhLMK2 a9IvNxU4D9Ai+d4Eqnstvb4AA1sij/Y8nzM9jnnjjUQL8PeqVooDyk7P7olQEvM5AJ+i/hI5G R2I4NcygAr/7C3cXT10SfA7VoCfA2Y0o2ud0rkw2DKQ64q8UbAFuwWoKB/sriQSQn3uv/nwQh TyM04L52aM8YS7ksQaY5+77aCCxCbjTcCgh1STced+nrPzhmvUHxYdAHZr26M4YkJd2FFjalD wYHkIKeMzG2VRzp7mLc2YNwciBTPVSquDxuHZDeoJIyC/viceabCZfGQr+pzE1FLuWkhN4LPw UltGYQInzKK56zpvX4/WG9OsnGwqVg+rnw4r0zZ31AxGIalhwYPBtks6x55zoXe4tis9iaqB/ MvaMZFQL9BOe2MuL4CfbucTfU8wt9faStw9LAc3oVVuhjprwoSDUPe7AZixOMpGRhXWiSz6/V Dv34TH8KPX3ZX6SOz0/lAXBUqU2SLYd8omXW9QOYdUGscGF3rt6mjNuwKv4MmzvmWyXSlQxaG 9xDEGsjKP2moDdL6WTW4kSZwWuYwiJ8gmlXq+dQ17StMhdJlNtczbfRwsT4PGTcHJMPImTFfS knZN+BC6xzk48/xnaZmbPdf5M8nOYqwSYMxu4xejjqHQ79J5xTszdmcGKrvP3mAO/3ArhV2s X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263969 Archived-At: On Thu, 22 Jun 2023 19:59:26 -0300 Mauro Aranda wr= ote: > Stephen Berman writes: > >>> Thanks for the feedback.=C2=A0 You're right, that patch is too superfic= ial; >>> it also fails to do substitution in popup extended menus like the one >>> produced by clicking the "State" button, with the result that in the >>> item "Revert This Session's Customization" the apostrophe is not >>> displayed in the "curve" style.=C2=A0 So I revised the patch, attached = below, >>> to iterate over the elements of each item in ITEMS, and it now appears >>> to handle substitution with the "State" button display correctly, both >>> as popup menu and as text menu buffer.=C2=A0 The latter is the result of >>> applying widget--simplify-menu, if I debugged correctly, so I think this >>> answers your concerns (though the text menu buffer already shows the >>> substitution independently of my patch, due to commit bd3b426ebb).=C2= =A0 Or >>> have I misunderstood your concerns about widget--simplify-menu?=C2=A0 I= f so, >>> can you give an example where the new patch fails? >> >> Just pinging in case this fell under the radar.=C2=A0 If there's no resp= onse, >> what's the next step forward? >> >> Steve Berman > > It did, thanks for the ping. > > Since there's no problem with widget--simplify-menu, the patch looks > good to me. Thanks. So Eli, should this go into master, since it's not a regression, or is it ok to install this to the release branch? It does seem pretty safe, since it's only applying substitute-command-keys in a few more places in widget-choose. Steve Berman