all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>,
	65156@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>,
	mail@lucaswerkmeister.de
Subject: bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported
Date: Wed, 09 Aug 2023 16:15:53 +0800	[thread overview]
Message-ID: <878raky6km.fsf@yahoo.com> (raw)
In-Reply-To: <76F5A77D-3461-4411-9716-7EF40F68722A@gmail.com> ("Mattias Engdegård"'s message of "Wed, 9 Aug 2023 10:07:55 +0200")

Mattias Engdegård <mattias.engdegard@gmail.com> writes:

> The current (4767f5eaee) code on emacs-29 fails fileio-tests with:
>
> Test fileio-tests--non-regular-insert condition:
>     (ert-test-failed
>      ((should-error
>        (insert-file-contents "/dev/urandom" nil 5 10))
>       :form
>       (insert-file-contents "/dev/urandom" nil 5 10)
>       :value
>       ("/dev/urandom" 5)
>       :fail-reason "did not signal an error"))

Right, but that's a problem with the test: /dev/urandom is seekable
under the Linux kernel.  I fixed this on master by checking for a
regular file instead of a seekable file when verifying BEG, but that's
too extensive a change for Emacs 29.






  reply	other threads:[~2023-08-09  8:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 18:20 bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported Lucas Werkmeister
2023-08-08 18:33 ` Eli Zaretskii
2023-08-08 19:27   ` Eli Zaretskii
2023-08-09  2:47     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09 11:31       ` Eli Zaretskii
2023-08-09 20:57     ` Paul Eggert
2023-08-10  5:17       ` Eli Zaretskii
2023-08-10  6:08         ` Paul Eggert
2023-08-10  8:15           ` Eli Zaretskii
2023-08-11 17:18             ` Paul Eggert
2023-08-11 18:30               ` Eli Zaretskii
2023-08-11 21:45                 ` Paul Eggert
2023-08-12  8:05                   ` Eli Zaretskii
2023-08-12  8:58                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09  8:07 ` Mattias Engdegård
2023-08-09  8:15   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-08-09  8:29     ` Mattias Engdegård
2023-08-09 12:00       ` Eli Zaretskii
2023-08-09 12:03         ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878raky6km.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=65156@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    --cc=mail@lucaswerkmeister.de \
    --cc=mattias.engdegard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.