Re: master c290b034e0f 1/2: Move `wholenump` alias definition

[Philip Kaludercic <philipk@posteo.net>]

Mattias Engdegård <mattiase@acm.org> writes:

> branch: master
> commit c290b034e0f9a2660e455b9dad471ff54c7a840c
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
>     Move `wholenump` alias definition
>     
>     * src/data.c (syms_of_data): From here...
>     * lisp/subr.el (wholenump): ...to here, with the other aliases.
> ---
>  lisp/subr.el | 1 +
>  src/data.c   | 2 --
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lisp/subr.el b/lisp/subr.el
> index 47fcbc2f317..0894a644d28 100644
> --- a/lisp/subr.el
> +++ b/lisp/subr.el
> @@ -2021,6 +2021,7 @@ instead; it will indirectly limit the specpdl stack size as well.")
>  (defalias 'store-match-data #'set-match-data)
>  (defalias 'chmod #'set-file-modes)
>  (defalias 'mkdir #'make-directory)
> +(defalias 'wholenump #'natnump)

I didn't know about this function (even though it appears to go back to
Emacs 19), but it might be confusing to some people.  In German "Ganze
Zahlen" (literally "whole numbers") is the term for integers, but
apparently Wikipedia[0] mentions that the term is ambiguous and might
refer both to ℤ and ℕ.  Is there anything that can be done about this?

[0] https://en.wikipedia.org/wiki/Whole_number

>  
>  ;; These were the XEmacs names, now obsolete:
>  (defalias 'point-at-eol #'line-end-position)
> diff --git a/src/data.c b/src/data.c
> index 377bcfce35d..9d6bf5a142c 100644
> --- a/src/data.c
> +++ b/src/data.c
> @@ -4369,8 +4369,6 @@ syms_of_data (void)
>    defsubr (&Sbool_vector_count_consecutive);
>    defsubr (&Sbool_vector_count_population);
>  
> -  set_symbol_function (Qwholenump, XSYMBOL (Qnatnump)->u.s.function);
> -
>    DEFVAR_LISP ("most-positive-fixnum", Vmost_positive_fixnum,
>  	       doc: /* The greatest integer that is represented efficiently.
>  This variable cannot be set; trying to do so will signal an error.  */);