From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Why have a #if .... #else .... #endif construct in Emacs Lisp, when we could make the existing code DTRT unchanged? Date: Tue, 05 Sep 2023 05:53:30 +0000 Message-ID: <878r9lw4h1.fsf@localhost> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22016"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: tomas@tuxteam.de Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 05 07:53:58 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdP0g-0005Xp-8A for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Sep 2023 07:53:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdOzl-00060f-FQ; Tue, 05 Sep 2023 01:53:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdOzb-0005zt-NH for emacs-devel@gnu.org; Tue, 05 Sep 2023 01:52:53 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdOzY-00026S-PH for emacs-devel@gnu.org; Tue, 05 Sep 2023 01:52:51 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5C8DC240027 for ; Tue, 5 Sep 2023 07:52:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693893165; bh=laVmGtonZ3vnuKT4YwybVGbPeHb8Ei8IFM6HZ/mCb5k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=bMlcyE03KcrMstDnjx1EG21ctWpdK1crphGjBClG+ZCFsvAX/TucCDZb/AbKVftMk zbk34mRQGIGvVuGOh/RtUo/UEVJzgIS1FFlpnFz3PEY8mTQiqUYRW26MWKplEM9EY0 1Z1NBomYcGxTWX7dJWJzFu6e1FjRDEC61cIwUC8IC5uIqOWwTfVeRQ5Hx7qvaj7KUJ Oz5UGBvVaBiOO5+NeVUpsOp5OCt1uxBhVE1HfmRRAkvdH3JYCB+nllzO+yhv9EWJ4I opiBUBFDhtpjSwoigTPGSOsDtbmhHWV1TqLjauTr29r9q52g5JtligiXM0DOzjAPGS 53FG8UDJJW8+g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RfvmX68gzz6tvm; Tue, 5 Sep 2023 07:52:44 +0200 (CEST) In-Reply-To: Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310110 Archived-At: writes: > I did offer one: checking for a version number is actually a placeholder > for the feature your code cares about. Better be up-front in the test > and let the reader know what your code's needs are. Not always. Sometimes, version check is necessary to work around bugs that exist in older Emacs. Example: (defun org-string-width (string &optional pixels) "Return width of STRING when displayed in the current buffer. Return width in pixels when PIXELS is non-nil." (if (and (version< emacs-version "28") (not pixels)) ;; FIXME: Fallback to old limited version, because ;; `window-pixel-width' is buggy in older Emacs. (org--string-width-1 string) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at